Skip to content

foreman: 0.78.0 -> 0.87.2#137086

Merged
domenkozar merged 1 commit intoNixOS:masterfrom
zimbatm:foreman-0.87.2
Sep 8, 2021
Merged

foreman: 0.78.0 -> 0.87.2#137086
domenkozar merged 1 commit intoNixOS:masterfrom
zimbatm:foreman-0.87.2

Conversation

@zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 8, 2021

Motivation for this change

CVE fixes #90776

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@domenkozar
Copy link
Member

@GrahamcOfBorg build foreman

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 8, 2021
@domenkozar domenkozar merged commit d7ac390 into NixOS:master Sep 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Successfully created backport PR #137087 for release-21.05.

@zimbatm zimbatm deleted the foreman-0.87.2 branch September 8, 2021 11:50
@jdelStrother
Copy link
Contributor

@zimbatm the PLATFORM change in Gemfile.lock seems to now prevent starting foreman in anything other than x86_64-linux.

$ foreman --help
Traceback (most recent call last):
	3: from /nix/store/7g9fqv28yfhv8r74gm13pj15wrckvxgp-foreman-0.87.2/bin/foreman:19:in `<main>'
	2: from /nix/store/s153awgiyhpwvwr02nlwkpygj3lnyb58-bundler-2.2.24/lib/ruby/gems/2.7.0/gems/bundler-2.2.24/lib/bundler.rb:143:in `setup'
	1: from /nix/store/s153awgiyhpwvwr02nlwkpygj3lnyb58-bundler-2.2.24/lib/ruby/gems/2.7.0/gems/bundler-2.2.24/lib/bundler/definition.rb:431:in `validate_runtime!'
/nix/store/s153awgiyhpwvwr02nlwkpygj3lnyb58-bundler-2.2.24/lib/ruby/gems/2.7.0/gems/bundler-2.2.24/lib/bundler/definition.rb:462:in `validate_platforms!': Your bundle only supports platforms ["x86_64-linux"] but your local platform is arm64-darwin-20. Add the current platform to the lockfile with `bundle lock --add-platform arm64-darwin-20` and try again. (Bundler::ProductionError)

Is that a product of bundling with bundler 2.2 rather than 2.1, or something else?

@zimbatm
Copy link
Member Author

zimbatm commented Sep 25, 2021

@jdelStrother can you try this PR? #139456 Looks like bundler has changed.

@jdelStrother
Copy link
Contributor

Thanks - looks promising. I'm away for a week though, will try it on my return

@jdelStrother
Copy link
Contributor

Sorry for the late reply, but yep - looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 85: foreman-0.78.0: 29 advisories [8.8]

3 participants