Skip to content

grpc: add patch to revert alias to abseil mutex#137456

Merged
marsam merged 1 commit intoNixOS:masterfrom
marsam:grpc-abseil-mutex-patch
Sep 12, 2021
Merged

grpc: add patch to revert alias to abseil mutex#137456
marsam merged 1 commit intoNixOS:masterfrom
marsam:grpc-abseil-mutex-patch

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Sep 12, 2021

Motivation for this change

Fixes #137055 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@marsam marsam mentioned this pull request Sep 12, 2021
Merged
12 tasks
@ofborg ofborg bot requested a review from LnL7 September 12, 2021 01:16
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Sep 12, 2021
@marsam
Copy link
Contributor Author

marsam commented Sep 12, 2021

@GrahamcOfBorg build sysdig
@GrahamcOfBorg build libtensorflow

@marsam marsam merged commit 22eb660 into NixOS:master Sep 12, 2021
@marsam marsam deleted the grpc-abseil-mutex-patch branch September 12, 2021 02:57
@mweinelt
Copy link
Member

mweinelt commented Mar 1, 2023

Patch dropped in #218614, tested libtensorflow and sysdig build to confirm it is not required anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marsam @mweinelt