Skip to content

grpc: 1.39.1 -> 1.40.0#137055

Merged
marsam merged 2 commits intoNixOS:masterfrom
marsam:update-grpc
Sep 8, 2021
Merged

grpc: 1.39.1 -> 1.40.0#137055
marsam merged 2 commits intoNixOS:masterfrom
marsam:update-grpc

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Sep 8, 2021

Motivation for this change

https://github.com/grpc/grpc/releases/tag/v1.40.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 8, 2021
@marsam
Copy link
Contributor Author

marsam commented Sep 8, 2021

@GrahamcOfBorg build murmur bear

@ofborg ofborg bot requested a review from LnL7 September 8, 2021 02:30
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Sep 8, 2021
@marsam marsam merged commit 0ecd963 into NixOS:master Sep 8, 2021
@marsam marsam deleted the update-grpc branch September 8, 2021 04:58
@orivej
Copy link
Contributor

orivej commented Sep 11, 2021

This update has broken libtensorflow and sysdig (and their dependents: https://hydra.nixos.org/eval/1702650#tabs-now-fail); the apparent cause is that grpc now generates code that has to be linked to libabsl_synchronization, but users of the generated code do not link to it.

@SuperSandro2000
Copy link
Member

Sounds like it needs to be added to propagatedBuildInputs.

@marsam
Copy link
Contributor Author

marsam commented Sep 12, 2021

@orivej sorry about that, it should be fixed by #137456

@marsam marsam mentioned this pull request Aug 6, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants