rocm: add update scripts#137117
Merged
lovesegfault merged 11 commits intoNixOS:masterfrom Sep 9, 2021
Merged
Conversation
Member
|
The upgrade has been done in #136445, however we probably still need other parts in this PR (for example the update script and the url fix), would you like to resolve the merge conflict? |
Member
Author
|
Oh my, even hip is in there. Thanks for the heads up, I’ll rebase. |
acowley
approved these changes
Sep 9, 2021
Contributor
acowley
left a comment
There was a problem hiding this comment.
These update scripts look terrific! What a great addition.
Member
|
Why do we even need this? Can't nix-update handle all of this? |
Member
Author
|
I didn’t know nix-update before. Seems like it needs a regex (like Using the update.nix script for all packages looks more convenient to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Tested OpenCL with an example and it still works.
To update everything with the update scripts:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)