Skip to content

rocm: add update scripts#137117

Merged
lovesegfault merged 11 commits intoNixOS:masterfrom
Flakebi:rocm
Sep 9, 2021
Merged

rocm: add update scripts#137117
lovesegfault merged 11 commits intoNixOS:masterfrom
Flakebi:rocm

Conversation

@Flakebi
Copy link
Member

@Flakebi Flakebi commented Sep 8, 2021

Motivation for this change

Tested OpenCL with an example and it still works.

To update everything with the update scripts:

for f in rocm-smi rocm-cmake rocm-thunk rocm-runtime rocm-opencl-runtime rocm-device-libs rocm-comgr rocclr rocminfo llvmPackages_rocm.llvm hip; nix-shell maintainers/scripts/update.nix --argstr commit true --argstr package $f; end
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Flakebi Flakebi requested review from acowley and danieldk September 8, 2021 17:46
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 8, 2021
@bobby285271
Copy link
Member

bobby285271 commented Sep 9, 2021

The upgrade has been done in #136445, however we probably still need other parts in this PR (for example the update script and the url fix), would you like to resolve the merge conflict?

@bobby285271 bobby285271 marked this as a duplicate of #136445 Sep 9, 2021
@bobby285271 bobby285271 marked this as not a duplicate of #136445 Sep 9, 2021
@Flakebi
Copy link
Member Author

Flakebi commented Sep 9, 2021

Oh my, even hip is in there. Thanks for the heads up, I’ll rebase.

@Flakebi Flakebi changed the title rocm: 4.1.0 -> 4.3.1 rocm: add update scripts Sep 9, 2021
@Flakebi Flakebi requested a review from lovesegfault September 9, 2021 12:56
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Sep 9, 2021
Copy link
Contributor

@acowley acowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These update scripts look terrific! What a great addition.

Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rocks!

@lovesegfault lovesegfault merged commit 8543834 into NixOS:master Sep 9, 2021
@Flakebi Flakebi deleted the rocm branch September 9, 2021 18:59
@SuperSandro2000
Copy link
Member

Why do we even need this? Can't nix-update handle all of this?

@Flakebi
Copy link
Member Author

Flakebi commented Sep 13, 2021

I didn’t know nix-update before. Seems like it needs a regex (like nix-update rocm-smi --version-regex 'rocm-(.*)'), it can’t update llvm and for some reason it also cannot update hip (Nix's builtins.parseDrvName could not parse the version from hip).

Using the update.nix script for all packages looks more convenient to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants