Skip to content

hip: init at 4.3.1#136445

Merged
lovesegfault merged 13 commits intoNixOS:masterfrom
lovesegfault:rocm-hip
Sep 8, 2021
Merged

hip: init at 4.3.1#136445
lovesegfault merged 13 commits intoNixOS:masterfrom
lovesegfault:rocm-hip

Conversation

@lovesegfault
Copy link
Member

@lovesegfault lovesegfault commented Sep 2, 2021 •
edited
Loading

Motivation for this change

Follow-up from nixos-rocm/nixos-rocm#65

cc. @acowley

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 2, 2021
@acowley
Copy link
Contributor

acowley commented Sep 2, 2021

Great to see this! Why version 4.0.0? It looks like the ROCm llvm here is at 4.1, and the nixos-rocm overlay is at 4.3.

@lovesegfault
Copy link
Member Author

lovesegfault commented Sep 2, 2021

Great to see this! Why version 4.0.0? It looks like the ROCm llvm here is at 4.1, and the nixos-rocm overlay is at 4.3.

Just because it's a 1-1 transplant from the code in nixos-rocm. I'm going to bump the versions now that I got the baseline working :)

@acowley
Copy link
Contributor

acowley commented Sep 2, 2021

Okay, let me know if you have any trouble. The overlay is working fine at 4.3 afaik.

@lovesegfault lovesegfault changed the title hip: init at 4.0.0 hip: init at 4.3.1 Sep 2, 2021
@lovesegfault
Copy link
Member Author

lovesegfault commented Sep 2, 2021

Alright, @acowley, I bumped our entire ROCm ecosystem to 4.3.1 and the new packages as well :)

@ofborg ofborg bot requested review from acowley and danieldk September 2, 2021 20:19
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Sep 2, 2021
@ofborg ofborg bot removed the 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. label Sep 2, 2021
@lovesegfault
Copy link
Member Author

lovesegfault commented Sep 2, 2021

Result of nixpkgs-review pr 136445 run on x86_64-linux 1

17 packages built:
  • hip
  • llvmPackages_rocm.clang
  • llvmPackages_rocm.clang-unwrapped
  • llvmPackages_rocm.clangNoCompilerRt
  • llvmPackages_rocm.compiler-rt
  • llvmPackages_rocm.lld
  • llvmPackages_rocm.llvm
  • rocclr
  • rocm-cmake
  • rocm-comgr
  • rocm-device-libs
  • rocm-opencl-icd
  • rocm-opencl-runtime
  • rocm-runtime
  • rocm-smi
  • rocm-thunk
  • rocminfo

@lovesegfault
Copy link
Member Author

lovesegfault commented Sep 3, 2021

@acowley If you could take a look at this I think it's ready to merge, I'd like a second opinion before hitting the button though :)

@risicle
Copy link
Contributor

risicle commented Sep 4, 2021

Is there any way to test/review this without hardware?

@lovesegfault
Copy link
Member Author

lovesegfault commented Sep 4, 2021

Is there any way to test/review this without hardware?

Not as far as I can tell, I have an AMD GPU and did some basic testing locally, where things looked fine.

acowley
acowley reviewed Sep 6, 2021
View reviewed changes
acowley
acowley reviewed Sep 6, 2021
View reviewed changes
@lovesegfault @acowley
hip: init at 4.3.1
75125b8 
Co-Authored-By: acowley <acowley@users.noreply.github.com>
@lovesegfault lovesegfault requested a review from acowley September 6, 2021 19:02
@lovesegfault lovesegfault merged commit 739c256 into NixOS:master Sep 8, 2021
@lovesegfault lovesegfault deleted the rocm-hip branch September 8, 2021 17:46
@lovesegfault
Copy link
Member Author

lovesegfault commented Sep 8, 2021

🥳

@cpground cpground mentioned this pull request Sep 9, 2021
Merged
@bobby285271 bobby285271 mentioned this pull request Sep 9, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@danieldk danieldk Awaiting requested review from danieldk

@acowley acowley Awaiting requested review from acowley

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lovesegfault @acowley @risicle