Skip to content

python39Packages.pomegranate: disable two failing tests #137081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
happysalada merged 1 commit into from
Sep 8, 2021
Merged

python39Packages.pomegranate: disable two failing tests #137081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkgs/development/python-modules/pomegranate/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ buildPythonPackage rec {
url = "https://github.com/jmschrei/pomegranate/commit/42d14bebc44ffd4a778b2a6430aa845591b7c3b7.patch";
sha256 = "0f9cx0fj9xkr3hch7jyrn76zjypilh5bqw734caaw6g2m49lvbff";
})
];
] ++ [
# Likely an upstream test bug and not a real problem:
# https://github.com/jmschrei/pomegranate/issues/939
./disable-failed-on-nextworkx-2.6.patch
] ;

propagatedBuildInputs = [ numpy scipy cython networkx joblib pyyaml ];

Expand Down
26 changes: 26 additions & 0 deletions pkgs/development/python-modules/pomegranate/disable-failed-on-nextworkx-2.6.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
Test started failing after upgrading networkx 2.5.1 -> 2.6.2:
https://github.com/jmschrei/pomegranate/issues/939

Failures look benigh.
--- a/tests/test_bayesian_network.py
+++ b/tests/test_bayesian_network.py
@@ -1057,7 +1057,8 @@ def test_exact_structure_learning_exclude_edges():
assert_not_equal(model.structure[-2], (d-1,))
assert_equal(model.structure[-2], (1,))

-def test_exact_dp_structure_learning_exclude_edges():
+# disabled for https://github.com/jmschrei/pomegranate/issues/939
+def disabled_exact_dp_structure_learning_exclude_edges():
for X in datasets:
X = X.copy()
X[:,1] = X[:,-1]
@@ -1139,7 +1140,8 @@ def test_constrained_parents_structure_learning_exclude_edges():
assert_equal(model.structure[7], (2,))
assert_equal(model.structure[4], (0,))

-def test_constrained_slap_structure_learning_exclude_edges():
+# disabled for https://github.com/jmschrei/pomegranate/issues/939
+def disabled_constrained_slap_structure_learning_exclude_edges():
for X in datasets:
X = X.copy()
X[:,1] = X[:,-1]