python39Packages.pomegranate: disable two failing tests#137081
Merged
happysalada merged 1 commit intoNixOS:masterfrom Sep 8, 2021
Merged
python39Packages.pomegranate: disable two failing tests#137081happysalada merged 1 commit intoNixOS:masterfrom
happysalada merged 1 commit intoNixOS:masterfrom
Conversation
Two tests started failing after commit cd7360f ("python38Packages.networkx: 2.5.1 -> 2.6.2"): test_exact_dp_structure_learning_exclude_edges test_constrained_slap_structure_learning_exclude_edges Both failures are triggered by networkx commit 15b74c552 ("Use bidirection_dijkstra as default in weighted shortest_path") My guess is that among equal paths the different one is picked. Which should be a benign test failure and not a real regression. Let's disable the tests to fix package building on master.
github-actions
bot
added
the
6.topic: python
Contributor
Author
|
Upstream bug report for posterity: jmschrei/pomegranate#939 |
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Fix looks good and well documented, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests started failing after commit cd7360f
("python38Packages.networkx: 2.5.1 -> 2.6.2"):
test_exact_dp_structure_learning_exclude_edges
test_constrained_slap_structure_learning_exclude_edges
Both failures are triggered by networkx commit 15b74c552
("Use bidirection_dijkstra as default in weighted shortest_path")
My guess is that among equal paths the different one is picked.
Which should be a benign test failure and not a real regression.
Let's disable the tests to fix package building on master.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)