Skip to content

luaformatter: fix darwin build#136297

Merged
happysalada merged 1 commit intoNixOS:masterfrom
figsoda:luaformatter-fix
Sep 8, 2021
Merged

luaformatter: fix darwin build#136297
happysalada merged 1 commit intoNixOS:masterfrom
figsoda:luaformatter-fix

Conversation

@figsoda
Copy link
Member

@figsoda figsoda commented Aug 31, 2021

Motivation for this change

fix #136290

I am not able test on darwin, but the same change fixes a similar issue here.
I would be great if someone can test it out for me

@jupblb @SuperSandro2000

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Aug 31, 2021
@ofborg ofborg bot requested a review from SuperSandro2000 August 31, 2021 14:58
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 31, 2021
@jupblb
Copy link
Contributor

jupblb commented Aug 31, 2021

Switching to gccStdenv (as a fix for MacOS) doesn't work after #134716. I guess one solution would be to revert it and merge this PR in order to support both platforms.

@figsoda
Copy link
Member Author

figsoda commented Aug 31, 2021

Not sure what is causing this issue.
on #123530 it builds on darwin
on #134669 it fails on darwin
There is no changes to luaformatter between these commits, might be changes to stdenv that is causing the issue

@figsoda
Copy link
Member Author

figsoda commented Aug 31, 2021

@ofborg build luaformatter

@figsoda figsoda marked this pull request as ready for review September 4, 2021 20:55
@happysalada
Copy link
Contributor

Just saying I'm running nixpkgs-review on darwin right now.

@happysalada
Copy link
Contributor

Result of nixpkgs-review pr 136297 run on x86_64-darwin 1

1 package built:
  • luaformatter

@happysalada
Copy link
Contributor

Thank you for the contribution!

@happysalada happysalada merged commit 7caefdd into NixOS:master Sep 8, 2021
@figsoda figsoda deleted the luaformatter-fix branch September 8, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

luaformatter doesn't build on MacOS

4 participants