Skip to content

luaformatter: combine with duplicate package lua-format, remove submo…#134716

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:luaformatter
Aug 18, 2021
Merged

luaformatter: combine with duplicate package lua-format, remove submo…#134716
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:luaformatter

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Aug 18, 2021

…dule usage

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Aug 18, 2021
@ofborg ofborg bot requested a review from figsoda August 18, 2021 21:34
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 18, 2021
@figsoda
Copy link
Member

figsoda commented Aug 18, 2021

Result of nixpkgs-review pr 134716 run on x86_64-linux 1

1 package built:
  • luaformatter

@figsoda
Copy link
Member

figsoda commented Aug 18, 2021

its nice to use the libraries from nixpkgs since upstream doesn't seem to update submodules too often

@SuperSandro2000 SuperSandro2000 merged commit 90fcdb5 into NixOS:master Aug 18, 2021
@SuperSandro2000 SuperSandro2000 deleted the luaformatter branch August 18, 2021 22:07
@jupblb jupblb mentioned this pull request Aug 31, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@figsoda figsoda figsoda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SuperSandro2000 @figsoda