WIP: Request to remove ruby 1.8 from the tree#1322
Merged
domenkozar merged 1 commit intoNixOS:masterfrom Mar 7, 2014
zimbatm:no-ruby18
Merged
WIP: Request to remove ruby 1.8 from the tree#1322domenkozar merged 1 commit intoNixOS:masterfrom zimbatm:no-ruby18
domenkozar merged 1 commit intoNixOS:masterfrom
zimbatm:no-ruby18
Conversation
Member
|
I don't think removing ruby18 is a good idea, it sitll may be useful to |
Member
Author
|
Maybe it would be worth applying that last round of patches then: https://blog.heroku.com/archives/2013/12/5/a_patch_in_time_securing_ruby |
ghost
assigned
Member
|
Looks good, feel free to open an issue to track progress for s3sync. |
domenkozar
added a commit
that referenced
this pull request
Mar 7, 2014
WIP: Request to remove ruby 1.8 from the tree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To continue the discussion on #1272 , ruby 1.8 is unsupported by the ruby dev team and has known vulnerability issues. I propose to we remove it from the tree.
There's two blockers: klinkstatus and s3sync.
klinkstatus seem to compile fine without ruby18 but I'm not sure exactly how the kde {} derivation work.
s3sync seems to be an old ruby1.8 script that interacts with S3. It doesn't seem to be maintained anymore: http://s3sync.net/wiki ( the new maintainer has just pushed 1 commit and didn't release anything). Either find a replacement, upgrade the script or just remove it all-together.
TODO: