Skip to content

Ruby security updates#1272

Closed
zimbatm wants to merge 5 commits intoNixOS:masterfrom
zimbatm:ruby-security-updates
Closed

Ruby security updates#1272
zimbatm wants to merge 5 commits intoNixOS:masterfrom
zimbatm:ruby-security-updates

Conversation

@zimbatm
Copy link
Member

@zimbatm zimbatm commented Nov 24, 2013

These commits fix the security issue described in CVE-2013-4164. Ruby 1.8.7 has also been updates but it still vulnerable to that CVE. Ruby 1.8.7 is not supported by the ruby core team and should probably be removed from the repo entirely.

The Darwin patch has also been imported from #1229

@zimbatm zimbatm mentioned this pull request Nov 24, 2013
@domenkozar
Copy link
Member

Looks good to me, haven't tried it yet.

@zimbatm
Copy link
Member Author

zimbatm commented Nov 25, 2013

I have tried 1.9.7 and 2.0.0 on OSX, 1.8.7 wasn't compiling in either versions

@bjornfor
Copy link
Contributor

+1.

Who wants to do the merge? :-)

@vcunat
Copy link
Member

vcunat commented Dec 2, 2013

There seem little risk in merging, and security updates are important (I'll just test it builds, together with texLive and munin). Thanks!

If there isn't a reason to keep ruby18, then it should be removed IMHO. I don't know/use ruby, so I'm leaving it for others to decide, but it seems clear as it's unsupported and vulnerable...

@vcunat
Copy link
Member

vcunat commented Dec 2, 2013

Pushed into master.

I wanted to merge it, but during testing someone updated master, so I rebased the merge commit, which resulted into a fast-forward merge and erasing my merge commit (I hope it doesn't matter).

@vcunat vcunat closed this Dec 2, 2013
@zimbatm
Copy link
Member Author

zimbatm commented Dec 2, 2013

I would remove the ruby18 package but I don't feel I have the position to do it. Some old software might depend on it since ruby 1.9 is not entirely backward-compatible.

@vcunat
Copy link
Member

vcunat commented Dec 2, 2013

Note: I see still one explicit reference to ruby18 in nixpkgs.

@zimbatm
Copy link
Member Author

zimbatm commented Dec 3, 2013

I looked at the latest tarball release and there seem to be no mention of ruby in the source. Weird. http://klinkstatus.kdewebdev.org/releases/klinkstatus-0.3.1.tar.bz2 . Maybe it would compile without the ruby18 derivation.

@zimbatm
Copy link
Member Author

zimbatm commented Dec 3, 2013

There's also s3sync who has a ruby18 override in the all-packages.nix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants