gnomeExtensions.material-shell: 12 -> 40.a#125975
gnomeExtensions.material-shell: 12 -> 40.a#125975arnarg wants to merge 1 commit intoNixOS:masterfrom arnarg:material-shell-40.a
Conversation
Gnome has been updated to 40 and that required all extensions to be changed to be made compatible. Version 12 of material-shell is not compatible with gnome 40 so it does not work with current version of gnome. This updates material-shell to version 40.a which is compatible with gnome 40. Since version 12 material-shell has been written in typescript so it needs to be compiled. Therefor I pull in all the development dependencies.
|
Did you see #124315? |
|
@jtojnar I did not. The version supporting Gnome 40 is currently not on extensions.gnome.org afaik should this be added as a manual build to that PR? |
|
Result of 1 package built successfully:
1 suggestion:
Result of 1 package built successfully:
|
|
I can drop the commit removing |
|
I don't know what would be best honestly. If the new version of the extension will be pushed to extensions.gnome.org that would be preferable of course. I can ask in their issue tracker. |
| cp -r dist/* $out/share/gnome-shell/extensions/${uuid}/ | ||
| runHook postInstall | ||
| ''; | ||
|
|
There was a problem hiding this comment.
license = licenses.mit;Though not related to this PR, just FYI, mateial-shell is GPL-3.0 license.
https://github.com/material-shell/material-shell
|
Thanks for your work. The manual packaging has been removed now and a version supporting Gnome 40 has been released, making this obsolete. The next update cycle is currently tracked in #126412. |
Motivation for this change
Gnome has been updated to 40 and that required all extensions to be changed to be made compatible. Version 12 of material-shell is not compatible with gnome 40 so it does not work with current version of gnome.
This updates material-shell to version 40.a which is compatible with gnome 40.
Since version 12 material-shell has been written in typescript so it needs to be compiled. Therefor I pull in all the development dependencies.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)