gnomeExtensions: Some more cleanup

[piegamesde]

Motivation for this change

• Packages have inconsistent names, let's fix them all gnomeExtensions.window-is-ready-remover: remove custom packaging and create alias #122921 (comment)
• Add aliases for backwards compatibility with regards to gnomeExtensions: normalize pnames #124295
• Also removed remove-dropdown-arrows, because it's old and obsolete.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Added a release notes entry if the change is major or breaking
• Fits CONTRIBUTING.md.

[jtojnar]

This looks like a typo.

[piegamesde]

Yes it very probably is. Nevertheless, this is the "official" name, and thus the name of the automatically packaged extension ¯_(ツ)_/¯

[jtojnar]

I would not consider that an official name – it is not used anywhere other than the slug on the extension portal website AFAICT.

[piegamesde]

Regarding passthru, I just recently realized that the manually packaged extensions simply expose uuid in the attrset and people may depend on this. I don't care how we do it out of these two options, but I'd like it to be consistent in some way.

[jtojnar]

This also sounds like something we should not need.

[piegamesde]

So my point is, the manually packaged extensions must somehow match the automatically packaged ones in order for overriding to work.

[jtojnar]

Could we do it in the other direction – rename the automatically packaged extension instead? Since the names are arbitrary, we might as well use ones that make sense.

[piegamesde]

Middle ground: I'd like to keep the pname the same, but I'd be fine with renaming the attribute name of the extensions (pname is almost worthless anyways).

The most promising approach at implementing this would be to key all manually packaged extensions with their UUID as well, so that I can first do the merge/override, and then give them proper names.

[jtojnar]

pname is what Repology uses so we should keep it somewhat canonical and reasonable.

I would say the easiest would be adding a section for changing bad slugs in extensionRenames.nix. But adding detection of duplicates based on UUID would be useful when people add a new manually packaged extension so that they choose a correct name.

[jtojnar]

Pushed the fix for the accidental rename as 571d540.

[piegamesde]

Second try, I almost started from scratch. No renames just yet, as they are less important with the improved merging. Personally, I'd like to rename all folders of the manually packaged extensions to use their UUID instead of their pname, but let me know what you think about this first.

[piegamesde]

So I went ahead and removed all manual packages that looked like the usual generic boilerplate. @chkno @jtojnar @emanueleperuffo @svsdep @hedning @tu-maurice @benley @Mdsp9070 @ericdallo @alesguzik @eduardosm @jonafato your extensions are affected. Please have a look and comment if any of them can not simply be replaced by the automatic packaging.

[piegamesde]

Let's summarize the discussion so far because the next time I'll have forgotten most of it:

• We should take a look a the pnames and compare with Repology
• The extensionPortalSlug can be normalized some more.
• Evaluate if some manual renames are worse than the extension portal slugs and drop them (adding legacy alias).
• (list will be expanded)

[jtojnar]

LGTM. Thanks for bearing with me.

[piegamesde]

Thanks for all the reviews