Skip to content

nixos/engelsystem: don't rely on mysql alias#125630

Merged
lukegb merged 1 commit intoNixOS:masterfrom
lukegb:fixeval
Jun 4, 2021
Merged

nixos/engelsystem: don't rely on mysql alias#125630
lukegb merged 1 commit intoNixOS:masterfrom
lukegb:fixeval

Conversation

@lukegb
Copy link
Contributor

@lukegb lukegb commented Jun 4, 2021

Motivation for this change

Fixing evaluation at master so we can get polkit out the door.

cc @FRidh @jonringer since this was broken (somewhat deliberately) by #103074

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

Since 3edde65, we can no longer use
aliases inside the test framework. This has the implication that we can
no longer use aliases in any NixOS modules used by the test framework as
well (which is good), but does mean we need to clean up any instances
where this is the case.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 4, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 4, 2021
@lukegb lukegb merged commit 1ca6b0a into NixOS:master Jun 4, 2021
@lukegb lukegb deleted the fixeval branch December 5, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant