Skip to content

make-test-python: disallow aliases#103074

Merged
jonringer merged 1 commit intoNixOS:masterfrom
FRidh:aliases
Jun 3, 2021
Merged

make-test-python: disallow aliases#103074
jonringer merged 1 commit intoNixOS:masterfrom
FRidh:aliases

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 7, 2020

When importing Nixpkgs within Nixpkgs, we should not consider aliases
to ensure we don't rely on them internally.

There are probably more places that need to be converted.

Triggered by #101369 (comment).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested review from ajs124 and tfc November 7, 2020 12:07
@FRidh
Copy link
Member Author

FRidh commented Nov 7, 2020

I expect evaluation errors.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 7, 2020
@SuperSandro2000
Copy link
Member

I expect evaluation errors.

Ofborg thinks differently.

@FRidh
Copy link
Member Author

FRidh commented Nov 7, 2020

Need to add it to the machine configuration instead.

@FRidh
Copy link
Member Author

FRidh commented Nov 7, 2020

@GrahamcOfBorg test plasma5

@FRidh FRidh added this to the 21.03 milestone Nov 7, 2020
When importing Nixpkgs within Nixpkgs, we should not consider aliases
to ensure we don't rely on them internally.

There are probably more places that need to be converted.
@jonringer
Copy link
Contributor

@GrahamcOfBorg test installer

@jonringer
Copy link
Contributor

just wanted to run some tests to make sure it wasn't fundamentally broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants