make-test-python: disallow aliases#103074
Merged
jonringer merged 1 commit intoNixOS:masterfrom Jun 3, 2021
Merged
Conversation
Member
Author
|
I expect evaluation errors. |
Member
Ofborg thinks differently. |
Member
Author
|
Need to add it to the machine configuration instead. |
FRidh
commented
Nov 7, 2020
Member
Author
|
@GrahamcOfBorg test plasma5 |
When importing Nixpkgs within Nixpkgs, we should not consider aliases to ensure we don't rely on them internally. There are probably more places that need to be converted.
SuperSandro2000
approved these changes
Nov 24, 2020
Artturin
approved these changes
Jun 3, 2021
jonringer
approved these changes
Jun 3, 2021
Contributor
|
@GrahamcOfBorg test installer |
Contributor
|
just wanted to run some tests to make sure it wasn't fundamentally broken |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When importing Nixpkgs within Nixpkgs, we should not consider aliases
to ensure we don't rely on them internally.
There are probably more places that need to be converted.
Triggered by #101369 (comment).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)