Skip to content

Comments

Qt5: use xcbuild on darwin#125572

Merged
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
prusnak:qt5-darwin
Jul 26, 2021
Merged

Qt5: use xcbuild on darwin#125572
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
prusnak:qt5-darwin

Conversation

@prusnak
Copy link
Member

@prusnak prusnak commented Jun 3, 2021 •
edited
Loading

Motivation for this change
  • don't use dontUseXcbuild in qtwebengine (dropped in 0534cea)
  • use xcbuild on darwin
  • this will hopefully enable future changes to bring Qt5 to aarch64-darwin
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested a review from ttuegel as a code owner June 3, 2021 21:41
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 3, 2021
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Jun 3, 2021
@prusnak prusnak mentioned this pull request Jun 3, 2021
Closed
9 tasks
@ofborg ofborg bot requested review from bkchr, matthewbauer, periklis and qknight June 3, 2021 21:50
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jun 3, 2021
@periklis periklis removed their request for review June 7, 2021 14:00
@ofborg ofborg bot requested a review from periklis June 25, 2021 20:09
@periklis periklis removed their request for review June 30, 2021 05:18
@prusnak prusnak changed the base branch from master to staging July 22, 2021 19:59
@prusnak prusnak changed the title Qt5 Darwin cleanup Qt5: use xcbuild on darwin Jul 22, 2021
@ofborg ofborg bot requested a review from periklis July 22, 2021 20:11
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jul 22, 2021
@ofborg ofborg bot added 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jul 22, 2021
@SuperSandro2000 SuperSandro2000 merged commit 4c095c5 into NixOS:staging Jul 26, 2021
@prusnak prusnak deleted the qt5-darwin branch July 26, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@bkchr bkchr Awaiting requested review from bkchr

@qknight qknight Awaiting requested review from qknight

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@periklis periklis Awaiting requested review from periklis

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prusnak @SuperSandro2000