Skip to content

Fix Qt 5.15 on Darwin, make it default#125548

Closed
prusnak wants to merge 3 commits intoNixOS:masterfrom
prusnak:qt5-darwin
Closed

Fix Qt 5.15 on Darwin, make it default#125548
prusnak wants to merge 3 commits intoNixOS:masterfrom
prusnak:qt5-darwin

Conversation

@prusnak
Copy link
Member

@prusnak prusnak commented Jun 3, 2021

Motivation for this change

I tried building qt512.qtbase, qt514.qtbase and qt515.qtbase on x86_64-darwin and it built successfully.

Coming up next: qt512.full, qt514.full and qt515.full ...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested a review from ttuegel as a code owner June 3, 2021 18:39
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 3, 2021
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Jun 3, 2021
@prusnak prusnak linked an issue Jun 3, 2021 that may be closed by this pull request
@ofborg ofborg bot requested review from bkchr, matthewbauer, periklis and qknight June 3, 2021 18:49
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jun 3, 2021
@prusnak
Copy link
Member Author

prusnak commented Jun 3, 2021

Hm, so qt515.full (more particularly qt515.qtwebengine) requires macOS 10.14 SDK (for Metal backend) after all.

Switching to Draft.

../../3rdparty/chromium/third_party/skia/src/gpu/mtl/GrMtlUtil.h:23:2: error: Must use at least 10.14 SDK to build Metal backend for MacOS
#error Must use at least 10.14 SDK to build Metal backend for MacOS
In file included from ../../3rdparty/chromium/third_party/skia/src/gpu/mtl/GrMtlGpu.mm:8:
In file included from ../../3rdparty/chromium/third_party/skia/src/gpu/mtl/GrMtlGpu.h:20:
../../3rdparty/chromium/third_party/skia/src/gpu/mtl/GrMtlCommandBuffer.h:47:31: error: no type or protocol named 'MTLEvent'
    void encodeSignalEvent(id<MTLEvent>, uint64_t value) SK_API_AVAILABLE(macos(10.14), ios(12.0));

@prusnak prusnak marked this pull request as draft June 3, 2021 20:20
@prusnak
Copy link
Member Author

prusnak commented Jun 3, 2021

Closing this, superseded by #125572 which cherry-picks the first two commits.

@smancill
Copy link
Contributor

Can a new issue be created, because this comment is misleading, and it's hard to track that even with #95199 closed it's still not ready:

  # TODO bump to 5.14 on darwin once it's not broken; see #95199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments