gnomeExtensions: normalize pnames#124295
Merged
jtojnar merged 1 commit intoNixOS:masterfrom May 24, 2021
Merged
Conversation
They should have gnome-shell-extension prefix like most other extension packages. This is what other distros listed on Repology use so Repology will be able to unify them. Exception is chrome-gnome-shell, which is estabilished under that name.
Member
|
Thanks. While you're at it, can you please make sure the manually packaged extensions have the "correct" name (i.e. the same as the automatically packaged ones)? #122921 (comment) Also, do we need to add aliases for backwards compatibility? |
Member
Author
|
Yeah, aliases will be needed. Cannot do that now. |
9 tasks
jtojnar
added a commit
that referenced
this pull request
May 25, 2021
I did not realize the attribute names are derived from the Nix package names so I accidentally, renamed them in #124295.
Member
|
Having a look at this again. You changed the pnames, but not the attributes. Doesn't this mean that no aliases are needed at all for compatibility? |
Member
Author
|
Yeah, I did not mean to change the attributes (corrected that in 571d540). I thought you were talking about the attributes that do not match the slugs, which I did not want to address here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
They should have gnome-shell-extension prefix like most other extension packages.
This is what other distros listed on Repology use so Repology will be able to unify them.
Exception is chrome-gnome-shell, which is estabilished under that name.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)