Skip to content

gnomeExtensions: normalize pnames#124295

Merged
jtojnar merged 1 commit intoNixOS:masterfrom
jtojnar:gnome-extension-cleanups
May 24, 2021
Merged

gnomeExtensions: normalize pnames#124295
jtojnar merged 1 commit intoNixOS:masterfrom
jtojnar:gnome-extension-cleanups

Conversation

@jtojnar
Copy link
Copy Markdown
Member

@jtojnar jtojnar commented May 24, 2021

Motivation for this change

They should have gnome-shell-extension prefix like most other extension packages.
This is what other distros listed on Repology use so Repology will be able to unify them.

Exception is chrome-gnome-shell, which is estabilished under that name.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

They should have gnome-shell-extension prefix like most other extension packages.
This is what other distros listed on Repology use so Repology will be able to unify them.

Exception is chrome-gnome-shell, which is estabilished under that name.
@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 24, 2021
@jtojnar jtojnar requested a review from piegamesde May 24, 2021 20:17
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 24, 2021
@piegamesde
Copy link
Copy Markdown
Member

Thanks. While you're at it, can you please make sure the manually packaged extensions have the "correct" name (i.e. the same as the automatically packaged ones)? #122921 (comment)

Also, do we need to add aliases for backwards compatibility?

@jtojnar jtojnar added the 9.needs: port to stable A PR needs a backport to the stable release. label May 24, 2021
@jtojnar
Copy link
Copy Markdown
Member Author

jtojnar commented May 24, 2021

Yeah, aliases will be needed. Cannot do that now.

@jtojnar jtojnar merged commit 5ba789e into NixOS:master May 24, 2021
@jtojnar jtojnar deleted the gnome-extension-cleanups branch May 24, 2021 21:41
jtojnar added a commit that referenced this pull request May 25, 2021
I did not realize the attribute names are derived from the Nix package names
so I accidentally, renamed them in #124295.
@jtojnar jtojnar removed the 9.needs: port to stable A PR needs a backport to the stable release. label May 25, 2021
@piegamesde
Copy link
Copy Markdown
Member

Having a look at this again. You changed the pnames, but not the attributes. Doesn't this mean that no aliases are needed at all for compatibility?

@jtojnar
Copy link
Copy Markdown
Member Author

jtojnar commented May 29, 2021

Yeah, I did not mean to change the attributes (corrected that in 571d540). I thought you were talking about the attributes that do not match the slugs, which I did not want to address here.

bjornfor pushed a commit that referenced this pull request Jun 22, 2021
I did not realize the attribute names are derived from the Nix package names
so I accidentally, renamed them in #124295.

(cherry picked from commit 571d540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants