Skip to content

revert #85073 & #85073#123889

Closed
ymatsiuk wants to merge 2 commits intoNixOS:masterfrom
ymatsiuk:pstore
Closed

revert #85073 & #85073#123889
ymatsiuk wants to merge 2 commits intoNixOS:masterfrom
ymatsiuk:pstore

Conversation

@ymatsiuk
Copy link
Contributor

@ymatsiuk ymatsiuk commented May 21, 2021

Motivation for this change

more details in #85073

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

ymatsiuk added 2 commits May 21, 2021 13:06
@ymatsiuk
Revert "Merge pull request NixOS#123360 from helsinki-systems/tasks_f…
686fe06 
…ilesystems_utillinux"

This reverts commit 036a962, reversing
changes made to 183350a.
@ymatsiuk
Revert "Merge pull request NixOS#85073 from hyperfekt/systemd-pstore"
b61e7a6 
This reverts commit 6c0058f, reversing
changes made to fb637b8.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels May 21, 2021
@ymatsiuk ymatsiuk requested a review from flokli May 21, 2021 11:10
@ymatsiuk ymatsiuk mentioned this pull request May 21, 2021
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 21, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 21, 2021 •
edited
Loading

Result of nixpkgs-review pr 123889 at b61e7a6 run on x86_64-linux 1

1 package failed to build:
  • nixos-install-tools
1 package built successfully:
  • tests.trivial

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 123889 at b61e7a6 run on aarch64-linux 1

1 package failed to build:
  • nixos-install-tools

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@ymatsiuk
Copy link
Contributor Author

ymatsiuk commented May 21, 2021

False alarm, the impact is pretty limited and only includes people with existing sys/fs/pstore. The fix is:

sudo umount /sys/fs/pstore
sudo nixos-rebuild switch

@ymatsiuk ymatsiuk closed this May 21, 2021
@ymatsiuk ymatsiuk deleted the pstore branch December 16, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flokli flokli Awaiting requested review from flokli

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ymatsiuk @r-rmcgibbo