Skip to content

nixos/tasks/filesystems: utillinux -> util-linux#123360

Merged
flokli merged 1 commit intoNixOS:masterfrom
helsinki-systems:tasks_filesystems_utillinux
May 17, 2021
Merged

nixos/tasks/filesystems: utillinux -> util-linux#123360
flokli merged 1 commit intoNixOS:masterfrom
helsinki-systems:tasks_filesystems_utillinux

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented May 17, 2021

Motivation for this change

fix eval

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 17, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 17, 2021
@flokli flokli merged commit 036a962 into NixOS:master May 17, 2021
@flokli
Copy link
Member

flokli commented May 17, 2021

Thanks for catching this! There seems to be other instances of this in nixpkgs, though?

nixos/modules/security/apparmor.nix
136:          logger = ${pkgs.utillinux}/bin/logger

pkgs/development/haskell-modules/hackage-packages.nix
114598:     , time-locale-compat, unordered-containers, utillinux, vector, wai
114622:       testToolDepends = [ utillinux ];
114627:     }) {inherit (pkgs) utillinux;};

@ajs124 ajs124 deleted the tasks_filesystems_utillinux branch May 17, 2021 13:38
@ajs124
Copy link
Member Author

ajs124 commented May 17, 2021

Yeah. Some of them set utillinux = pkgs.util-linux;, but others don't.

The apparmor one probably doesn't get evaluated on any of my systems, hence why I didn't notice it.

@ghost
Copy link

ghost commented May 17, 2021

Thanks.

ymatsiuk added a commit to ymatsiuk/nixpkgs that referenced this pull request May 21, 2021
…ilesystems_utillinux"

This reverts commit 036a962, reversing
changes made to 183350a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants