pari: 2.11.4 -> 2.13.1, update sage test expectations#122624
Merged
timokau merged 1 commit intoNixOS:masterfrom May 19, 2021
Merged
pari: 2.11.4 -> 2.13.1, update sage test expectations#122624timokau merged 1 commit intoNixOS:masterfrom
timokau merged 1 commit intoNixOS:masterfrom
Conversation
This was referenced May 11, 2021
Merged
Member
|
@ofborg eval |
Member
Author
|
@timokau This the upstream ticket now has a |
timokau
approved these changes
May 19, 2021
Member
There was a problem hiding this comment.
I think positive review and no new feedback for 7 days is good enough to get this into 20.05. Luckily we won't have to compromise between sage stability and a recent pari. I assume the "draft" status is only because the PR was dependent on the upstream ticket, so I'll ignore it.
The changes themselves look good. Thank you for staying on this.
10 tasks
Member
Author
|
@timokau Thank you for caring deeply about Sage stability, and thank you for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #102699 without breaking Sage. We will wait until the Sage patch is upstreamed, though (see #122592 (review)).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)