Skip to content

Comments

pari: 2.11.4 -> 2.13.1, update sage test expectations#122624

Merged
timokau merged 1 commit intoNixOS:masterfrom
collares:pari-2.13
May 19, 2021
Merged

pari: 2.11.4 -> 2.13.1, update sage test expectations#122624
timokau merged 1 commit intoNixOS:masterfrom
collares:pari-2.13

Conversation

@collares
Copy link
Member

Motivation for this change

Fixes #102699 without breaking Sage. We will wait until the Sage patch is upstreamed, though (see #122592 (review)).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@collares collares marked this pull request as draft May 11, 2021 19:53
This was referenced May 11, 2021
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 11, 2021
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label May 12, 2021
@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label May 13, 2021
@cole-h
Copy link
Member

cole-h commented May 13, 2021

@ofborg eval

@collares
Copy link
Member Author

@timokau This the upstream ticket now has a positive_review. There are many options: wait for the next Sage beta, wait for the 21.05 branch to be cut, and so on. Let me know what you prefer :)

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think positive review and no new feedback for 7 days is good enough to get this into 20.05. Luckily we won't have to compromise between sage stability and a recent pari. I assume the "draft" status is only because the PR was dependent on the upstream ticket, so I'll ignore it.

The changes themselves look good. Thank you for staying on this.

@timokau timokau marked this pull request as ready for review May 19, 2021 14:06
@timokau timokau merged commit 6cf6470 into NixOS:master May 19, 2021
@collares
Copy link
Member Author

@timokau Thank you for caring deeply about Sage stability, and thank you for the review!

@collares collares deleted the pari-2.13 branch May 19, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants