sage: 9.3rc4 -> 9.3

[collares]

Motivation for this change

Also updated gap and pari while at it. Pari required an unmerged patch from Sage Trac, but the patch hasn't changed in two weeks so that should be fine. Let me know if I should remove it, though.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[collares]

Related: The eclib update patch has stabilized too, even if it hasn't been merged yet. Should we pull that in as well? My main motivation for doing pari first is that I believe there are many standalone PARI/GP users so it's a bit unfair to them to ship NixOS 21.05 with an outdated version.

[r-rmcgibbo]

Result of nixpkgs-review pr 122592 at ee7c058d run on aarch64-linux 1

1 package marked as broken and skipped:

• polymake

3 packages skipped due to time constraints:

• giac
• giac-with-xcas
• python39Packages.fpylll

16 packages built successfully:

• eclib
• gap
• gap-full
• gap-minimal
• lcalc
• pari
• pynac
• python38Packages.cypari2
• python38Packages.cysignals
• python38Packages.fpylll
• python38Packages.pplpy
• python39Packages.cypari2
• python39Packages.cysignals
• python39Packages.pplpy
• singular
• sympow

---

Result of nixpkgs-review pr 122592 at ee7c058d run on x86_64-linux 1

6 packages skipped due to time constraints:

• giac
• giac-with-xcas
• polymake
• python38Packages.pplpy
• sage
• sageWithDoc

17 packages built successfully:

• eclib
• gap
• gap-full
• gap-minimal
• gp2c
• lcalc
• pari
• pynac
• python38Packages.cypari2
• python38Packages.cysignals
• python38Packages.fpylll
• python39Packages.cypari2
• python39Packages.cysignals
• python39Packages.fpylll
• python39Packages.pplpy
• singular
• sympow

7 suggestions:

• warning: unused-argument

  Unused argument: fetchpatch.
  Near pkgs/applications/science/math/pari/default.nix:3:3:

    |
  3 | , fetchpatch
    |   ^
  

• warning: unclear-gpl

  gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

  Near pkgs/applications/science/math/gap/default.nix:157:5:

      |
  157 |     license = licenses.gpl2;
      |     ^
  

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/applications/science/math/singular/default.nix:146:3:

      |
  146 |   installPhase = ''
      |   ^
  

• warning: unclear-gpl

  gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

  Near pkgs/applications/science/math/pynac/default.nix:87:5:

     |
  87 |     license = licenses.gpl3;
     |     ^
  

• warning: unused-argument

  Unused argument: fetchpatch.
  Near pkgs/applications/science/math/gap/default.nix:4:3:

    |
  4 | , fetchpatch
    |   ^
  

• warning: missing-phase-hooks

  buildPhase should probably contain runHook preBuild and runHook postBuild.

  Near pkgs/applications/science/math/singular/default.nix:140:3:

      |
  140 |   buildPhase = ''
      |   ^
  

• warning: unclear-gpl

  gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

  Near pkgs/applications/science/math/singular/default.nix:210:5:

      |
  210 |     license = licenses.gpl3; # Or GPLv2 at your option - but not GPLv4
      |     ^
  

[collares]

Result of nixpkgs-review pr 122592 run on x86_64-linux 1

23 packages built:

• eclib
• gap
• gap-full
• gap-minimal
• giac
• giac-with-xcas
• gp2c
• lcalc
• pari
• polymake
• pynac
• python38Packages.cypari2
• python38Packages.cysignals
• python38Packages.fpylll
• python38Packages.pplpy
• python39Packages.cypari2
• python39Packages.cysignals
• python39Packages.fpylll
• python39Packages.pplpy
• sage (sagemath)
• sageWithDoc
• singular
• sympow

[timokau]

Thanks for following up on this. I would prefer to delay the pari update until the sage ticket has been reviewed. It looks like this update is likely to cause trouble.

The other changes look good.

[timokau]

Related: The eclib update patch has stabilized too, even if it hasn't been merged yet. Should we pull that in as well? My main motivation for doing pari first is that I believe there are many standalone PARI/GP users so it's a bit unfair to them to ship NixOS 21.05 with an outdated version.

Which ticket is that?

In general I think it would be better to merge this PR first. The eclib update could still be done as a followup.

[collares]

That's https://trac.sagemath.org/ticket/31443. I have split the pari update to #122624.

[timokau]

That's https://trac.sagemath.org/ticket/31443.

Ah, I forgot about this conversation. That update sounds less risky than the pari update. I think there also isn't much urgency to it though, so I would probably wait a few days for updates on the sage ticket. Whichever way you prefer.

I have split the pari update to #122624.

Thank you. Should be good to go now.

[timokau]

Looks good, pending ofBorg's approval.

[collares]

@timokau Thank you for the review! I will have an eclib PR soon.

Edit: That's #123692.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/brainstorming-for-rfc-pname-and-version/12873/23

[AndersonTorres]

LGTBorg