Skip to content

Comments

tachyon: disable threading on aarch64 to avoid sage test hangs#117465

Merged
timokau merged 2 commits intoNixOS:masterfrom
collares:sage-jmol
Mar 29, 2021
Merged

tachyon: disable threading on aarch64 to avoid sage test hangs#117465
timokau merged 2 commits intoNixOS:masterfrom
collares:sage-jmol

Conversation

@collares
Copy link
Member

@collares collares commented Mar 24, 2021

Motivation for this change

Something changed on master between March 11th and March 20th and Sage tests that use Tachyon for 3D graphics started hanging on aarch64 (the links are to succeeding and failing ofBorg testruns). I don't have an aarch64 machine so it's hard for me to bisect the problem, but disabling multithreading makes the bug go away.

@timokau, is this an acceptable solution?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@collares collares marked this pull request as draft March 24, 2021 12:45
@collares collares mentioned this pull request Mar 24, 2021
10 tasks
@collares collares force-pushed the sage-jmol branch 2 times, most recently from 090b310 to 8d18148 Compare March 24, 2021 13:04
@ofborg ofborg bot requested review from 7c6f434c and timokau March 24, 2021 13:14
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2021
@collares collares force-pushed the sage-jmol branch 7 times, most recently from 1a694a4 to add8e3c Compare March 24, 2021 22:07
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Mar 24, 2021
@collares collares force-pushed the sage-jmol branch 3 times, most recently from b0e76a2 to 8dc044c Compare March 25, 2021 02:09
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Mar 25, 2021
@collares collares force-pushed the sage-jmol branch 5 times, most recently from 25d28e4 to 8ee55ec Compare March 25, 2021 11:39
@collares collares changed the title sage: jmol debug tachyon: disable threading on aarch64 to avoid sage test hangs Mar 25, 2021
@collares collares marked this pull request as ready for review March 25, 2021 12:16
@collares
Copy link
Member Author

@ofborg build sage

@collares
Copy link
Member Author

@timokau I am not in a hurry at all to get this merged as I don't even have access to an aarch64 system, but I thought I'd send a "this is ready (for feedback, at least)" ping just because you probably got a billion emails from my force pushes while this PR was still a draft. This fixes Sage aarch64 tests on ofBorg.

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to bisect the issue, but I already got test timeouts on aarch64 right after the sage 9.2 update (#105615). The aarch64 support of sage on nix was never exactly first class, so this might go back even further.

Thank you for tracking it down. I left a comment requesting some "breadcrumbs" for future adventurers. After that this PR should be good to go.

@ofborg ofborg bot requested a review from 7c6f434c March 29, 2021 19:38
@timokau timokau merged commit 42aad39 into NixOS:master Mar 29, 2021
@collares collares deleted the sage-jmol branch March 29, 2021 22:43
@collares collares mentioned this pull request Sep 20, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants