tachyon: disable threading on aarch64 to avoid sage test hangs#117465
Merged
timokau merged 2 commits intoNixOS:masterfrom Mar 29, 2021
Merged
tachyon: disable threading on aarch64 to avoid sage test hangs#117465timokau merged 2 commits intoNixOS:masterfrom
timokau merged 2 commits intoNixOS:masterfrom
Conversation
10 tasks
090b310 to
8d18148
Compare
1a694a4 to
add8e3c
Compare
b0e76a2 to
8dc044c
Compare
25d28e4 to
8ee55ec
Compare
Member
Author
|
@ofborg build sage |
Member
Author
|
@timokau I am not in a hurry at all to get this merged as I don't even have access to an aarch64 system, but I thought I'd send a "this is ready (for feedback, at least)" ping just because you probably got a billion emails from my force pushes while this PR was still a draft. This fixes Sage aarch64 tests on ofBorg. |
7c6f434c
approved these changes
Mar 29, 2021
timokau
requested changes
Mar 29, 2021
Member
timokau
left a comment
There was a problem hiding this comment.
I tried to bisect the issue, but I already got test timeouts on aarch64 right after the sage 9.2 update (#105615). The aarch64 support of sage on nix was never exactly first class, so this might go back even further.
Thank you for tracking it down. I left a comment requesting some "breadcrumbs" for future adventurers. After that this PR should be good to go.
timokau
approved these changes
Mar 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Something changed on master between March 11th and March 20th and Sage tests that use Tachyon for 3D graphics started hanging on aarch64 (the links are to succeeding and failing ofBorg testruns). I don't have an aarch64 machine so it's hard for me to bisect the problem, but disabling multithreading makes the bug go away.
@timokau, is this an acceptable solution?
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)