Skip to content

jmol: 14.31.32 -> 14.31.34#115980

Merged
tomberek merged 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/jmol
Mar 14, 2021
Merged

jmol: 14.31.32 -> 14.31.34#115980
tomberek merged 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/jmol

Conversation

@r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jmol/versions.

meta.description for jmol is: "A Java 3D viewer for chemical structures"

meta.homepage for jmol is: "https://sourceforge.net/projects/jmol"

meta.changelog for jmol is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
6 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
jmol
sage
sageWithDoc
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/p5dfn8hfi605g7cqyks70xbf9v2w30hg-jmol-14.31.34 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A jmol https://github.com/r-ryantm/nixpkgs/archive/1e0c7594567de1b20aa035111b3df174d6b7386d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/p5dfn8hfi605g7cqyks70xbf9v2w30hg-jmol-14.31.34
ls -la /nix/store/p5dfn8hfi605g7cqyks70xbf9v2w30hg-jmol-14.31.34/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review took longer than 45m and timed out


Maintainer pings

cc @Mounium @timokau @omasanori @7c6f434c for testing.

@ofborg ofborg bot requested review from 7c6f434c, omasanori and timokau March 11, 2021 19:49
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 11, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 11, 2021

Result of nixpkgs-review pr 115980 at 1e0c759 run on x86_64-linux 1

2 packages skipped due to time constraints:
  • sage
  • sageWithDoc
1 package built successfully:
3 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/science/chemistry/jmol/default.nix:34:3:

       |
    34 |   installPhase = ''
       |   ^
    
  • warning: patch-phase

    patchPhase should not be overridden, use postPatch instead.

    Near pkgs/applications/science/chemistry/jmol/default.nix:30:3:

       |
    30 |   patchPhase = ''
       |   ^
    
  • warning: unclear-gpl

    lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.

    Near pkgs/applications/science/chemistry/jmol/default.nix:49:6:

       |
    49 |      license = licenses.lgpl2;
       |      ^
    

Result of nixpkgs-review pr 115980 at 1e0c759 run on aarch64-linux 1

1 package built successfully:
3 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/science/chemistry/jmol/default.nix:34:3:

       |
    34 |   installPhase = ''
       |   ^
    
  • warning: patch-phase

    patchPhase should not be overridden, use postPatch instead.

    Near pkgs/applications/science/chemistry/jmol/default.nix:30:3:

       |
    30 |   patchPhase = ''
       |   ^
    
  • warning: unclear-gpl

    lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.

    Near pkgs/applications/science/chemistry/jmol/default.nix:49:6:

       |
    49 |      license = licenses.lgpl2;
       |      ^
    

@collares
Copy link
Member

@ofborg build sage

@tomberek tomberek merged commit 29bf7e2 into NixOS:master Mar 14, 2021
@r-ryantm r-ryantm deleted the auto-update/jmol branch March 15, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants