supercollider: fix Qt wrapping#117333
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Apr 7, 2021
Merged
Conversation
|
Result of 5 packages built successfully:
|
turion
reviewed
Mar 23, 2021
turion
requested changes
Mar 23, 2021
Contributor
turion
left a comment
There was a problem hiding this comment.
Thanks :) It can be tightened in two places:
- It seems like
dontWrapQtAppscan be removed completely, and thepostFixupphase removed - In
all-packages.nix, it should saylibsForQt5instead oflibsForQt514I think.
731ab0b to
06353a2
Compare
Contributor
Author
That's in the Edit: The version in |
Contributor
Ah my bad, I was looking at an outdated branch from last year that still had |
turion
approved these changes
Mar 23, 2021
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't know how to use this package, but it launches. I've only wrapped the binaries that depend on Qt.
Motivation for this change
#116548, cc @turion
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)