Skip to content

supercollider: fix Qt wrapping#117333

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
OPNA2608:fix/supercollider-wrapping/21.05
Apr 7, 2021
Merged

supercollider: fix Qt wrapping#117333
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
OPNA2608:fix/supercollider-wrapping/21.05

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Mar 23, 2021

Don't know how to use this package, but it launches. I've only wrapped the binaries that depend on Qt.

grafik

Motivation for this change

#116548, cc @turion

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from MrMebelMan March 23, 2021 09:58
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 23, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 117333 at 731ab0b6 run on x86_64-linux 1

5 packages built successfully:
  • python38Packages.foxdot
  • python39Packages.foxdot
  • sonic-pi
  • supercollider
  • supercollider_scel

Copy link
Contributor

@turion turion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) It can be tightened in two places:

  1. It seems like dontWrapQtApps can be removed completely, and the postFixup phase removed
  2. In all-packages.nix, it should say libsForQt5 instead of libsForQt514 I think.

@OPNA2608 OPNA2608 force-pushed the fix/supercollider-wrapping/21.05 branch from 731ab0b to 06353a2 Compare March 23, 2021 11:35
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Mar 23, 2021

  1. In all-packages.nix, it should say libsForQt5 instead of libsForQt514 I think.

That's in the release-20.09 branch, this PR is against master which has libsForQt5.

Edit: The version in release-20.09 is also outdated and apparently incompatible with Qt 5.15, hence the pinning to Qt 5.14. Looks like this bump wasn't backported to stable: #104431

@turion
Copy link
Contributor

turion commented Mar 23, 2021

  1. In all-packages.nix, it should say libsForQt5 instead of libsForQt514 I think.

That's in the release-20.09 branch, this PR is against master which has libsForQt5.

Ah my bad, I was looking at an outdated branch from last year that still had libsForQt514. Then everything is looking great!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/363

@SuperSandro2000 SuperSandro2000 merged commit b219457 into NixOS:master Apr 7, 2021
@OPNA2608 OPNA2608 deleted the fix/supercollider-wrapping/21.05 branch September 27, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants