Skip to content

supercollider: 3.11.0 -> 3.11.2#104431

Merged
jonringer merged 1 commit intoNixOS:masterfrom
freezeboy:migrate-supercollider
Nov 23, 2020
Merged

supercollider: 3.11.0 -> 3.11.2#104431
jonringer merged 1 commit intoNixOS:masterfrom
freezeboy:migrate-supercollider

Conversation

@freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 20, 2020 •
edited
Loading

Motivation for this change

This update allows to migrate to Qt5.15

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
Copy link
Contributor Author

freezeboy commented Nov 21, 2020

Related to #104474

@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

@GrahamcOfBorg eval

@FRidh FRidh added the 6.topic: qt/kde Object-oriented framework for GUI creation label Nov 21, 2020
@ofborg ofborg bot removed the 6.topic: qt/kde Object-oriented framework for GUI creation label Nov 21, 2020
@ofborg ofborg bot requested a review from MrMebelMan November 21, 2020 10:31
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 21, 2020
@RaghavSood
Copy link
Member

RaghavSood commented Nov 23, 2020

Result of nixpkgs-review pr 104431 1

6 packages built:
  • python27Packages.foxdot
  • python37Packages.foxdot
  • python38Packages.foxdot
  • sonic-pi
  • supercollider
  • supercollider_scel

jonringer
jonringer approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104431 1

6 packages built:
  • python27Packages.foxdot
  • python37Packages.foxdot
  • python38Packages.foxdot
  • sonic-pi
  • supercollider
  • supercollider_scel

@freezeboy freezeboy deleted the migrate-supercollider branch November 23, 2020 15:12
@OPNA2608 OPNA2608 mentioned this pull request Mar 23, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrMebelMan MrMebelMan Awaiting requested review from MrMebelMan

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@freezeboy @FRidh @RaghavSood @jonringer