Skip to content

adoptopenjdk-{13,14}: mark insecure#116935

Merged
taku0 merged 1 commit intoNixOS:masterfrom
hercules-ci:unsupported-jdks
Mar 21, 2021
Merged

adoptopenjdk-{13,14}: mark insecure#116935
taku0 merged 1 commit intoNixOS:masterfrom
hercules-ci:unsupported-jdks

Conversation

@roberth
Copy link
Member

@roberth roberth commented Mar 19, 2021

Motivation for this change

These JDKs are end-of-life, so shouldn't be used.
15 is also at or close to eol, but I haven't marked that one. It'd be nice if we could provide 16 first.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth roberth added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 19, 2021
@roberth
Copy link
Member Author

roberth commented Mar 19, 2021

I also noticed that the adoptopenjdk attributes are functions instead of packages. Is this for a reason? It seems nicer for users to be able to just use these as packages without having to call them first.

nix-repl> adoptopenjdk-bin-15-packages-linux.jdk-hotspot                     
«lambda @ /home/user/h/nixpkgs/pkgs/development/compilers/adoptopenjdk-bin/jdk-linux-base.nix:3:1»

nix-repl> callPackage adoptopenjdk-bin-15-packages-linux.jdk-hotspot {}
«derivation /nix/store/d8h2zq4lpclcn6c2mqjxq78bqi6hcg83-adoptopenjdk-hotspot-bin-15.0.1.drv»

@roberth roberth requested a review from taku0 March 19, 2021 15:43
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 19, 2021
@roberth roberth mentioned this pull request Mar 19, 2021
10 tasks
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@taku0 taku0 merged commit aaa9453 into NixOS:master Mar 21, 2021
@taku0
Copy link
Contributor

taku0 commented Mar 21, 2021

Could you make a backporting PR?

@taku0 taku0 mentioned this pull request Mar 21, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants