Skip to content

adoptopenjdk: add 16.0.0#116781

Merged
taku0 merged 1 commit intoNixOS:masterfrom
cust0dian-old:adoptopenjdk-16
Mar 26, 2021
Merged

adoptopenjdk: add 16.0.0#116781
taku0 merged 1 commit intoNixOS:masterfrom
cust0dian-old:adoptopenjdk-16

Conversation

@cust0dian-old
Copy link
Contributor

Motivation for this change

Java 16 builds are now available

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 18, 2021
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can the build increase but the download stays the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 that's what AdoptOpenJDK API responds with:

$ curl -s https://api.adoptopenjdk.net/v2/latestAssets/releases/openjdk13 | jq 'map(select(.os == "linux" and .architecture == "aarch64" and .binary_type == "jdk"))[0]'
{
  "os": "linux",
  "architecture": "aarch64",
  "binary_type": "jdk",
  "openjdk_impl": "hotspot",
  "binary_name": "OpenJDK13U-jdk_aarch64_linux_hotspot_13.0.2_8.tar.gz",
  "binary_link": "https://github.com/AdoptOpenJDK/openjdk13-binaries/releases/download/jdk-13.0.2%2B8/OpenJDK13U-jdk_aarch64_linux_hotspot_13.0.2_8.tar.gz",
  "binary_size": 206018212,
  "checksum_link": "https://github.com/AdoptOpenJDK/openjdk13-binaries/releases/download/jdk-13.0.2%2B8/OpenJDK13U-jdk_aarch64_linux_hotspot_13.0.2_8.tar.gz.sha256.txt",
  "version": "13",
  "version_data": {
    "openjdk_version": "13.0.2+8",
    "semver": "13.0.2+8.1"
  },
  "heap_size": "normal",
  "download_count": 3076,
  "updated_at": "2020-01-21T09:21:39Z",
  "timestamp": "2020-01-21T09:21:39Z",
  "release_name": "jdk-13.0.2+8",
  "release_link": "https://github.com/AdoptOpenJDK/openjdk13-binaries/releases/tag/jdk-13.0.2%2B8"
}

see semver in version_data: that's what is being used in generate-sources.py (I just run generate-sources.py to update sources.json for the reference, didn't edit it manually)

If I were to guess, maybe something changed in AdoptOpenJDK's build process for those versions, but the underlying source and expected output is the same?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. I don't know. It just looked strange and maybe something is broken or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like #113120 landed into master now so updates to Java 8-15 releases are no longer part of this PR (sorry, I didn't notice there was already a PR for those updates), so this PR is purely about adding Java 16 releases now

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 20, 2021
@cust0dian-old cust0dian-old changed the title adoptopenjdk: 8.0.272 -> 8.0.282, 11.0.9 -> 11.0.10, 15.0.1 -> 15.0.2, add 16 adoptopenjdk: add 16.0.0 Mar 20, 2021
@taku0
Copy link
Contributor

taku0 commented Mar 21, 2021

#116935 is merged. Please update this PR too.

@cust0dian-old
Copy link
Contributor Author

@taku0 thanks for the heads up, updated this PR to be in line with those changes

@taku0 taku0 merged commit 44ccf96 into NixOS:master Mar 26, 2021
@cust0dian-old cust0dian-old deleted the adoptopenjdk-16 branch March 28, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants