darwin x11/opengl: only copy subset of pkgconfigs#1165
Closed
kowey wants to merge 1 commit intoNixOS:masterfrom
Closed
darwin x11/opengl: only copy subset of pkgconfigs#1165kowey wants to merge 1 commit intoNixOS:masterfrom
kowey wants to merge 1 commit intoNixOS:masterfrom
Conversation
Copy only the pc files related to X11 and OpenGL. This should allow us to build our own version of libraries like cairo without having the native ones be accidentally dynamically linked in to things that depend on them. Before this patch if we `dyldinfo -dylibs libpangocairo` we can see that it was dynamically linked against the OS X (but seemingly built against include files from the nix one, as we would get a runtime complaint about missing symbols)
Member
|
This looks a good idea. Many things on darwin were done very hastily, and it causes problem. I suppose there could be many other packages under /usr/X11. Let's test it together with #1160 in x-updates (which has closer config to master than stdenv-updates). |
vcunat
pushed a commit
that referenced
this pull request
Nov 5, 2013
Copy only the pc files related to X11 and OpenGL. This should allow us to build our own version of libraries like cairo without having the native ones be accidentally dynamically linked in to things that depend on them. Before this patch if we `dyldinfo -dylibs libpangocairo` we can see that it was dynamically linked against the OS X (but seemingly built against include files from the nix one, as we would get a runtime complaint about missing symbols)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy only the pc files related to X11 and OpenGL.
This should allow us to build our own version of libraries like
cairo without having the native ones be accidentally dynamically
linked in to things that depend on them.
Before this patch if we
dyldinfo -dylibs libpangocairowe cansee that it was dynamically linked against the OS X (but seemingly
built against include files from the nix one, as we would get a
runtime complaint about missing symbols)
This fixes an issues I was experiencing where if I ran graphviz from a GUI app (but not when I ran it from the terminal), I would get a complaint like this:
And further inspection of that dylib would reveal /usr/X11/lib/libcairo…