Skip to content

Avoid --no-cpp-precomp for Perl on darwin#1160

Closed
kowey wants to merge 1 commit intoNixOS:masterfrom
kowey:kowey-macosx
Closed

Avoid --no-cpp-precomp for Perl on darwin#1160
kowey wants to merge 1 commit intoNixOS:masterfrom
kowey:kowey-macosx

Conversation

@kowey
Copy link
Contributor

@kowey kowey commented Nov 2, 2013

vcunat added a commit that referenced this pull request Nov 2, 2013
@vcunat
Copy link
Member

vcunat commented Nov 2, 2013

I put it into stdenv-updates straight away (I only renamed the patch). It only affects darwin, so maybe we can cherry-pick to master soon, too?

@kowey
Copy link
Contributor Author

kowey commented Nov 2, 2013

Apologies for the unrelated commit; didn't realise that just pushing to my branch would cause a notification on the pull request (which kind of makes sense in hindsight). Guess it'll have to be one branch per mini patch in the future

@domenkozar
Copy link
Member

You can remove the commit and force push to cleanup

@kowey
Copy link
Contributor Author

kowey commented Nov 2, 2013

OK, done.

@vcunat
Copy link
Member

vcunat commented Nov 2, 2013

In fact it doesn't send any notification and just silently changes the pull request.

@vcunat
Copy link
Member

vcunat commented Nov 5, 2013

Build results look very good. http://hydra.nixos.org/eval/1018092#tabs-now-succeed

vcunat added a commit that referenced this pull request Nov 5, 2013
Taken from https://trac.macports.org/ticket/38913
vcunat renamed the patch

Conflicts (trivial):
	pkgs/development/interpreters/perl/5.16/default.nix
@vcunat vcunat closed this in 0eeee29 Nov 7, 2013
@vcunat
Copy link
Member

vcunat commented Nov 7, 2013

It's in master now.

Ah, I mistakenly took authorship of the commit when I was renaming the patch, I'm sorry.

@kowey
Copy link
Contributor Author

kowey commented Nov 7, 2013

Heh, just happy to see MacOS progress :-)

@kowey kowey deleted the kowey-macosx branch November 7, 2013 18:45
vcunat added a commit that referenced this pull request Jan 17, 2014
Taken from https://trac.macports.org/ticket/38913
vcunat renamed the patch

Conflicts (trivial):
	pkgs/development/interpreters/perl/5.16/default.nix

(cherry picked from commit 0eeee29)
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
Taken from https://trac.macports.org/ticket/38913
vcunat renamed the patch

Conflicts (trivial):
	pkgs/development/interpreters/perl/5.16/default.nix

(cherry picked from commit 0eeee29)
This was referenced Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants