cython: 0.29.21 -> 0.29.22, backport Cython 3.0 trashcan support#115200
cython: 0.29.21 -> 0.29.22, backport Cython 3.0 trashcan support#115200SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
Conversation
|
Updated the package version while I'm at it. |
SuperSandro2000
left a comment
There was a problem hiding this comment.
I build up to home-assistant which failed due to an unrelated error. If @jonringer or @FRidh approve it this can be merged.
FRidh
left a comment
There was a problem hiding this comment.
This is fine, but you will be responsible then for keeping the patch up to date. When it does not apply, and blocks cython, it may get removed.
|
Deal! This patch is two years old, was made for Cython 0.29.5 and hasn't bitrotted yet, so I think it's unlikely to ever block Cython (well, until Cython 3.0 gets released, at which point the patch should be removed). But if it happens I'll update the patch. |
|
@FRidh I just noticed #114452 while rebasing patches that depended on this. I am afraid the cypari2 upgrade there could cause Sage test failures, so can this land on staging-next directly? If not, I would be grateful if you could drop the cypari2 update from #114452 (7a3db26) so I could land it on staging along with Sage test fixes. Thanks! |
No, its too big a rebuild and staging-next has been stuck already too long.
Feel free to open a PR with a revert if it is needed. I see now it isn't the first time. |
Users of Sage may get random stack overflows on large object deallocations without this patch. It backports Cython 3.0 trashcan support to Cython 0.X.
This patch does not affect Python code unless the code explicitly uses the feature, which is both an argument for patching the global Cython (it's fairly safe) and for making sage use a modified Cython, since only a modified cypari2 will use this change. Just let me know if applying the patch globally is a bad idea, I won't be offended :) In fact, I didn't run nixpkgs-review because it rebuilds everything that uses Python.
(I can also just work around the Sage test failure instead of applying the patch at all, but users can still sporadically hit the problem during normal use.)
cc @omasanori @timokau This is causing the totallyreal.pyx aarch64 failure in the dependency update PR, I believe.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)