sage: adapt eclib test expected output, revert cypari2 update#114747
sage: adapt eclib test expected output, revert cypari2 update#114747SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Conversation
|
@ofborg build sage |
|
@omasanori @timokau @7c6f434c This is now ready for review. Note that I initially tried to upgrade to eclib 20210226, but this new version causes extra test failures so we must be careful to not let other people update it for the time being. I reported this at JohnCremona/eclib#64, and the conclusion is that Sage requires a patch to set precision parameters properly under eclib 20210226. The eclib 20210226 extra failures are: |
|
not sure what's prevening Sage's upgrade of eclib, apart from labour shortages. |
This reverts commit 7a3db26. Updating this requires fixing Sage tests, which will be done in a separate PR.
|
I have added a separate commit reverting the cypari2 update that just landed on master, because it is causing test failures on aarch64. Upgrading cypari2 properly will be done on staging now that #115200 has been merged. |
|
@SuperSandro2000 Thanks for merging! It's much appreciated. |
Motivation for this change
eclib was updated in #114425, but the test output changed slightly. Upstream is still on eclib 20190909, so I cannot just import an upstream patch.
Should unbreak sage. I've verified that the test outputs are the same up to minor formatting changes.