Skip to content

python3Packages.parso: fix flaky test due to slow moving time#114257

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
bobrik:ivan/slow-moving-parso
Feb 26, 2021
Merged

python3Packages.parso: fix flaky test due to slow moving time#114257
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
bobrik:ivan/slow-moving-parso

Conversation

@bobrik
Copy link
Contributor

@bobrik bobrik commented Feb 24, 2021

Motivation for this change

This primarily helps with #105026, since otherwise Hydra machines aren't failing on these tests.

Similar to #114255.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Feb 24, 2021
@Mic92
Copy link
Member

Mic92 commented Feb 24, 2021

/rebase staging

@github-actions github-actions bot changed the base branch from master to staging February 24, 2021 18:14
@github-actions github-actions bot force-pushed the ivan/slow-moving-parso branch from 997e3f8 to b4976c2 Compare February 24, 2021 18:14
@github-actions github-actions bot closed this Feb 24, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2021

Rebased, please reopen the pull request to restart CI

@Mic92 Mic92 reopened this Feb 24, 2021
@bobrik bobrik mentioned this pull request Feb 25, 2021
Merged
10 tasks
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 25, 2021

@ofborg build python3Packages.parso

@SuperSandro2000 SuperSandro2000 merged commit b0ca5ad into NixOS:staging Feb 26, 2021
@bobrik bobrik mentioned this pull request Feb 27, 2021
Merged
21 tasks
@bobrik bobrik deleted the ivan/slow-moving-parso branch March 6, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobrik @Mic92 @SuperSandro2000