Skip to content

python3Packages.curio: fix flaky test due to slow moving time#114255

Merged
Mic92 merged 1 commit intoNixOS:stagingfrom
bobrik:ivan/slow-moving-curio
Feb 25, 2021
Merged

python3Packages.curio: fix flaky test due to slow moving time#114255
Mic92 merged 1 commit intoNixOS:stagingfrom
bobrik:ivan/slow-moving-curio

Conversation

@bobrik
Copy link
Contributor

@bobrik bobrik commented Feb 24, 2021

Motivation for this change

This primarily helps with #105026, since otherwise Hydra machines aren't failing on these tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bobrik bobrik mentioned this pull request Feb 24, 2021
Merged
10 tasks
@ofborg ofborg bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 24, 2021
@ofborg ofborg bot requested a review from marsam February 24, 2021 17:10
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Feb 24, 2021
@bobrik
Copy link
Contributor Author

bobrik commented Feb 24, 2021

/rebase staging

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2021

Failed to rebase

@bobrik bobrik force-pushed the ivan/slow-moving-curio branch from ff56c86 to 62e729b Compare February 24, 2021 20:31
@bobrik bobrik changed the base branch from master to staging February 24, 2021 20:31
@ofborg ofborg bot added 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Feb 24, 2021
@ofborg ofborg bot added 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim Advanced text editor 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Feb 24, 2021
@ofborg ofborg bot removed the request for review from zowoq February 24, 2021 20:40
@Mic92 Mic92 merged commit 54ac9ef into NixOS:staging Feb 25, 2021
@bobrik
Copy link
Contributor Author

bobrik commented Feb 25, 2021

@Mic92 any chance you can look into #114257? It's basically the same thing.

This was referenced Feb 27, 2021
Merged
Merged
@bobrik bobrik deleted the ivan/slow-moving-curio branch March 6, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@marsam marsam Awaiting requested review from marsam

@alyssais alyssais Awaiting requested review from alyssais

@andir andir Awaiting requested review from andir

@danieldk danieldk Awaiting requested review from danieldk

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@rycee rycee Awaiting requested review from rycee

@stigtsp stigtsp Awaiting requested review from stigtsp

@teto teto Awaiting requested review from teto

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim Advanced text editor 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobrik @Mic92