Skip to content

httplz: dropping maintainership#110372

Merged
Ma27 merged 1 commit intoNixOS:masterfrom
bbigras:httplz
Jan 22, 2021
Merged

httplz: dropping maintainership#110372
Ma27 merged 1 commit intoNixOS:masterfrom
bbigras:httplz

Conversation

@bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 21, 2021

Motivation for this change

Upstream doesn't want to include Cargo.lock in the repo. This made updating this package automatically impossible.

We have other great tools like oneshot.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 21, 2021
@SuperSandro2000
Copy link
Member

Maybe want to remove the package completely?

@bbigras
Copy link
Contributor Author

bbigras commented Jan 21, 2021

Maybe want to remove the package completely?

Yeah, that's what I wanted but after reading #110179 I'm not sure anymore.

@Ma27 Ma27 merged commit 932d885 into NixOS:master Jan 22, 2021
@bbigras bbigras deleted the httplz branch January 22, 2021 21:14
@bbigras
Copy link
Contributor Author

bbigras commented Jan 22, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants