Skip to content

treewide: remove orphaned packages#110179

Closed
kampka wants to merge 1 commit intoNixOS:masterfrom
kampka:remove-orphans
Closed

treewide: remove orphaned packages#110179
kampka wants to merge 1 commit intoNixOS:masterfrom
kampka:remove-orphans

Conversation

@kampka
Copy link
Contributor

@kampka kampka commented Jan 20, 2021

Motivation for this change

Requested by @Mic92 in #109813 (comment)

@kampka kampka marked this pull request as ready for review January 20, 2021 15:03
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 20, 2021
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add throw aliases for all of them and remove them from top level to make ofborg happy.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 20, 2021
Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 I know you asked Kampka to do this, but IMO this is a bad idea as long as we don't have popcon-like information about which packages are used. For instance, I know that mdadm was maintainer-less when I noticed it had last been updated since a quite long time ago when looking into a bug, and at that time I “took over” maintainership (though in practice it's not like mdadm is very active a project anyway so I haven't been doing that much).

All that to say, IMO even orphaned packages have some potentially significant value, at least so long as there are no known security vulnerabilities in them — removing them when there's no longer any maintainer listed basically means that we decide that nixpkgs is only a distribution for people who do maintain packages.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/new-nixpkgs-maintainer-wanted-for-trilium-server-gandi-cli-matrix-appservice-slack-and-spacegund/11095/1

@Mic92
Copy link
Member

Mic92 commented Jan 21, 2021

@Mic92 I know you asked Kampka to do this, but IMO this is a bad idea as long as we don't have popcon-like information about which packages are used. For instance, I know that mdadm was maintainer-less when I noticed it had last been updated since a quite long time ago when looking into a bug, and at that time I “took over” maintainership (though in practice it's not like mdadm is very active a project anyway so I haven't been doing that much).

All that to say, IMO even orphaned packages have some potentially significant value, at least so long as there are no known security vulnerabilities in them — removing them when there's no longer any maintainer listed basically means that we decide that nixpkgs is only a distribution for people who do maintain packages.

They also create work if we do treewide refactoring i.e. updating a central library that might break some other packages i.e. #109113 I asked on discourse if anyone wants to keep any of these packages. Also they make nixpkgs-review slower.

@bbigras bbigras mentioned this pull request Jan 21, 2021
10 tasks
@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 22, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@kevincox
Copy link
Contributor

I agree. I think we should remove them if no one is stepping up. The packages will still live on in Git and are trivial to add back if someone wants to step up at some point in the future.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 25, 2021
@SuperSandro2000
Copy link
Member

Mic92 I know you asked Kampka to do this, but IMO this is a bad idea as long as we don't have popcon-like information about which packages are used. For instance, I know that mdadm was maintainer-less when I noticed it had last been updated since a quite long time ago when looking into a bug, and at that time I “took over” maintainership (though in practice it's not like mdadm is very active a project anyway so I haven't been doing that much).

mdadm is by default installed on other Distros and it is reasonable to assume that it is an important package unlike the ones that are removed here.

All that to say, IMO even orphaned packages have some potentially significant value, at least so long as there are no known security vulnerabilities in them — removing them when there's no longer any maintainer listed basically means that we decide that nixpkgs is only a distribution for people who do maintain packages.

If you are using a package which lags a maintainer and it is to significant value to you than you should step up as a maintainer otherwise the package will degrade over time. We can't put the maintenance burden of maintainerless packages onto the community and fix time along side when doing major updates of other packages. Maintainers can take away some of the burden and fix packages quickly after they broke in nixpkgs-unstable and it is very important that people actually use those packages in their day to day live to find more indepth bugs which someone just checking if the program starts would have never found.

@aanderse
Copy link
Member

I always thought an Ubuntu style "multiverse" repo would be a good solution to this problem. See this discourse thread for additional discussion on the topic.

@kampka kampka closed this Aug 25, 2021
@kampka kampka deleted the remove-orphans branch August 25, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up This PR removes packages or removes other cruft 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants