Skip to content

darwin: explicitly mark broken for failed building apple packages #108651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veprbl merged 2 commits into from
Jan 16, 2021
Merged

darwin: explicitly mark broken for failed building apple packages #108651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f6e651
darwin.hfs: mark broken
holymonson Jan 7, 2021
b9be150
darwin.libauto: mark broken and drop stdenv.lib
holymonson Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkgs/os-specific/darwin/apple-source-releases/hfs/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,10 @@ appleDerivation {
mkdir -p $out/include/hfs
cp core/*.h $out/include/hfs
'';

meta = {
# Seems nobody wants its binary, so we didn't implement building.
broken = !headersOnly;
platforms = lib.platforms.darwin;
};
}
8 changes: 5 additions & 3 deletions pkgs/os-specific/darwin/apple-source-releases/libauto/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{ stdenv, appleDerivation, libdispatch, Libsystem }:
{ lib, stdenv, appleDerivation, libdispatch, Libsystem }:

appleDerivation {
# these are included in the pure libc
buildInputs = stdenv.lib.optionals stdenv.cc.nativeLibc [ libdispatch Libsystem ];
buildInputs = lib.optionals stdenv.cc.nativeLibc [ libdispatch Libsystem ];

buildPhase = ''
cp ${./auto_dtrace.h} ./auto_dtrace.h
Expand Down Expand Up @@ -79,6 +79,8 @@ appleDerivation {
'';

meta = {
platforms = stdenv.lib.platforms.darwin;
# libauto is only used by objc4/pure.nix , but objc4 is now using the impure approach, so we don't bother to fix this.
broken = true;
platforms = lib.platforms.darwin;
};
}