darwin: explicitly mark broken for failed building apple packages#108651
Merged
veprbl merged 2 commits intoNixOS:masterfrom Jan 16, 2021
Merged
darwin: explicitly mark broken for failed building apple packages#108651veprbl merged 2 commits intoNixOS:masterfrom
veprbl merged 2 commits intoNixOS:masterfrom
Conversation
10 tasks
Member
|
Please move those two changes into two commits and name them properly. I imagine something like |
Member
|
Result of 2 packages marked as broken and skipped:
Can you also make those packages darwin only? |
bd1baaa to
1bc2183
Compare
Member
|
@holymonson please resolve the eval error. |
1bc2183 to
ea2f8f9
Compare
veprbl
reviewed
Jan 12, 2021
pkgs/os-specific/darwin/apple-source-releases/libauto/default.nix
Outdated
Show resolved
Hide resolved
SuperSandro2000
approved these changes
Jan 13, 2021
ea2f8f9 to
b9be150
Compare
veprbl
approved these changes
Jan 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We are trying to update and clean apple packages, so we explicitly mark broken for those mean to fail building.
Things done
Mark
hfsandlibautobroken.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)