Skip to content

ghostwriter: 1.0.1 -> 2.0.0-rc3, build with newest libsForQt5#108474

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
erictapen:ghostwriter-2.0.0
Jan 7, 2021
Merged

ghostwriter: 1.0.1 -> 2.0.0-rc3, build with newest libsForQt5#108474
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
erictapen:ghostwriter-2.0.0

Conversation

@erictapen
Copy link
Member

Motivation for this change

ghostwriter currently fails to build on nixos-unstable, also address #104474.

Things done

Bumped to latest release candidate.

@dotlambda what do you think, should we update to 2.0.0-rc3? Alternatiely I could convert this PR to draft and wait until 2.0.0 gets released.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dotlambda January 5, 2021 12:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 5, 2021
@ymarkus ymarkus added the 8.has: package (update) This PR updates a package to a newer version label Jan 5, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108474 run on x86_64-linux 1

1 package built:
  • ghostwriter

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 7, 2021

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108474 run on x86_64-darwin 1

1 package failed to build and are new build failure:
  build flags: -j4 -l4 SHELL=/nix/store/4n2ah3plbfnfz14wrzmz1pkfw78y9kz4-bash-4.4-p23/bin/bash
  /nix/store/wb2m935kldwcn1nwqc3j1n1k5ncqbq71-qttools-5.12.9-dev/bin/lrelease -silent translations/ghostwriter_ar.ts -qm build/release/translations/ghostwriter_ar.qm
  /nix/store/wb2m935kldwcn1nwqc3j1n1k5ncqbq71-qttools-5.12.9-dev/bin/lrelease -silent translations/ghostwriter_ca.ts -qm build/release/translations/ghostwriter_ca.qm
  /nix/store/wb2m935kldwcn1nwqc3j1n1k5ncqbq71-qttools-5.12.9-dev/bin/lrelease -silent translations/ghostwriter_cs.ts -qm build/release/translations/ghostwriter_cs.qm
  /nix/store/wb2m935kldwcn1nwqc3j1n1k5ncqbq71-qttools-5.12.9-dev/bin/lrelease -silent translations/ghostwriter_de.ts -qm build/release/translations/ghostwriter_de.qm
  make: *** [Makefile:921: build/release/translations/ghostwriter_de.qm] Segmentation fault: 11
  make: *** Waiting for unfinished jobs....
  make: *** [Makefile:915: build/release/translations/ghostwriter_ca.qm] Segmentation fault: 11
  make: *** [Makefile:918: build/release/translations/ghostwriter_cs.qm] Segmentation fault: 11
  make: *** [Makefile:912: build/release/translations/ghostwriter_ar.qm] Segmentation fault: 1

Please mark it as broken on darwin or set the platforms to linux only if upstream does not support darwin.

- mark as broken on darwin
- add myself as maintainer
@erictapen
Copy link
Member Author

Upstream seems to support it, at least there are issues about macOS. Marked as broken on darwin. @SuperSandro2000

@SuperSandro2000 SuperSandro2000 merged commit 7a5c1d3 into NixOS:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants