Skip to content

ghostwriter: 1.0.1 -> 2.0.0-rc3, build with newest libsForQt5#108473

Closed
erictapen wants to merge 1 commit intoNixOS:masterfrom
erictapen:ghostscript-3.0.0
Closed

ghostwriter: 1.0.1 -> 2.0.0-rc3, build with newest libsForQt5#108473
erictapen wants to merge 1 commit intoNixOS:masterfrom
erictapen:ghostscript-3.0.0

Conversation

@erictapen
Copy link
Member

@erictapen erictapen commented Jan 5, 2021 •
edited
Loading

Motivation for this change

ghostwriter currently fails to build on nixos-unstable, also address #104474.

Things done

Bumped to latest release candidate.

@dotlambda what do you think, should we update to 2.0.0-rc3? Alternatiely I could convert this PR to draft and wait until 2.0.0 gets released.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
Copy link
Member Author

erictapen commented Jan 5, 2021

Closing in favor of #108474, i messed up my branch names m(

@erictapen erictapen closed this Jan 5, 2021
@erictapen erictapen deleted the ghostscript-3.0.0 branch January 5, 2021 12:36
@ofborg ofborg bot requested a review from dotlambda January 5, 2021 12:40
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 5, 2021
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 6, 2021

Closing in favor of #108474, i messed up my branch names m(

branch names do not matter to much tbh

@erictapen
Copy link
Member Author

erictapen commented Jan 6, 2021

They just matter for my personal organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erictapen @SuperSandro2000