Skip to content

pythonPackages.afdko: 3.5.1 -> 3.6.0#107412

Closed
sternenseemann wants to merge 1 commit intoNixOS:masterfrom
sternenseemann:afdko-3.6.0-only
Closed

pythonPackages.afdko: 3.5.1 -> 3.6.0#107412
sternenseemann wants to merge 1 commit intoNixOS:masterfrom
sternenseemann:afdko-3.6.0-only

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Dec 22, 2020 •
edited
Loading

Motivation for this change

https://github.com/adobe-type-tools/afdko/blob/3.6.0/NEWS.md#360-released-2020-12-17

Needs merge of dependency updates first:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 22, 2020
SuperSandro2000
SuperSandro2000 requested changes Dec 23, 2020
View reviewed changes
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 23, 2020

Result of nixpkgs-review pr 107412 run on x86_64-darwin 1

7 packages failed to build:
  • noto-fonts-emoji
  • python37Packages.afdko
  • python37Packages.nototools
  • python38Packages.afdko
  • python38Packages.nototools
  • python39Packages.afdko
  • python39Packages.nototools

afdko:

error: [Errno 2] No such file or directory: 'c/build_all/detype1'

@sternenseemann
Copy link
Member Author

sternenseemann commented Dec 23, 2020

Expected right now, since required changes are not yet merged (see first comment). Just wanted to open this so it's visible that there has been some work done towards an afdko update :)

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@sternenseemann
Copy link
Member Author

sternenseemann commented Feb 28, 2021

@ofborg build python3Packages.afdko python3Packages.nototools

@sternenseemann sternenseemann marked this pull request as ready for review February 28, 2021 16:59
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 28, 2021
@sternenseemann sternenseemann deleted the afdko-3.6.0-only branch March 2, 2021 21:39
@sternenseemann sternenseemann restored the afdko-3.6.0-only branch July 24, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sternenseemann @SuperSandro2000