Skip to content

pythonPackages.lxml: 4.5.2 -> 4.6.2#107408

Merged
dotlambda merged 1 commit intoNixOS:stagingfrom
sternenseemann:lxml-4.6.1
Feb 13, 2021
Merged

pythonPackages.lxml: 4.5.2 -> 4.6.2#107408
dotlambda merged 1 commit intoNixOS:stagingfrom
sternenseemann:lxml-4.6.1

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Dec 22, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann sternenseemann added 1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python Python is a high-level, general-purpose programming language. labels Dec 22, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 22, 2020
@sternenseemann sternenseemann mentioned this pull request Dec 22, 2020
Closed
14 tasks
@jonringer
Copy link
Contributor

jonringer commented Dec 22, 2020

do you mind targeting staging, 5000+ rebuilds

@sternenseemann sternenseemann changed the base branch from master to staging December 22, 2020 16:59
@sternenseemann
Copy link
Member Author

sternenseemann commented Dec 22, 2020

Done!

@jonringer
Copy link
Contributor

jonringer commented Dec 22, 2020

@ofborg build pandas

@jonringer
Copy link
Contributor

jonringer commented Dec 22, 2020

@GrahamcOfBorg build python3Packages.pandas

@ofborg ofborg bot added 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch and removed 6.topic: GNOME GNOME desktop environment and its underlying platform labels Dec 22, 2020
@ofborg ofborg bot removed 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 22, 2020
@jonringer
Copy link
Contributor

jonringer commented Dec 22, 2020

@GrahamcOfBorg eval

@ruuda
Copy link
Contributor

ruuda commented Jan 8, 2021

Did Ofborg get stuck on this one? The Darwin checks still show up as queued.

@sternenseemann
Copy link
Member Author

sternenseemann commented Jan 8, 2021

Did Ofborg get stuck on this one? The Darwin checks still show up as queued.

I recall that there was some kind of general issue with the darwin builders for ofborg.

@zowoq zowoq removed their request for review January 9, 2021 23:28
@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 29, 2021
@dotlambda
Copy link
Member

dotlambda commented Jan 29, 2021

@ofborg build pandas python3Packages.pandas

@sternenseemann
Copy link
Member Author

sternenseemann commented Feb 13, 2021

Any news on this?

@dotlambda dotlambda merged commit b14d8ba into NixOS:staging Feb 13, 2021
@sternenseemann sternenseemann deleted the lxml-4.6.1 branch February 13, 2021 12:49
dotlambda pushed a commit that referenced this pull request Feb 13, 2021
@sternenseemann @dotlambda
pythonPackages.lxml: 4.5.2 -> 4.6.2 (#107408)
0473d24 
(cherry picked from commit b14d8ba)
@dotlambda dotlambda added 8.has: port to stable This PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 13, 2021
@bobrik bobrik mentioned this pull request Mar 17, 2021
Merged
10 tasks
@bobrik
Copy link
Contributor

bobrik commented Mar 17, 2021

#116669 fixes broken builds for Darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python Python is a high-level, general-purpose programming language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

Python batch upgrade
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sternenseemann @jonringer @ruuda @dotlambda @bobrik