bitwarden: 1.23.0 -> 1.23.1 #105850
bitwarden: 1.23.0 -> 1.23.1 #105850
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
|
Result of 1 package failed to build:
|
|
|
Hmm, both main suspects (tracker wrapper changes and meson bump) are already on master so it must be something else. |
|
Looks like there is a regression in systemd --- /nix/store/6fkka81sc5w9ip4y5mnlw56w73jhzs5f-systemd-246.6-dev/share/pkgconfig/systemd.pc
+++ /nix/store/9dr7dzc4lywln6swpma98gwppx688mr0-systemd-247-dev/share/pkgconfig/systemd.pc
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: LGPL-2.1+
+# SPDX-License-Identifier: LGPL-2.1-or-later
#
# This file is part of systemd.
#
@@ -11,8 +11,8 @@
# considered deprecated (though there is no plan to remove them). New names
# shall have underscores.
-prefix=/nix/store/iyayrhagfqccsrfzw2fqs2q8n4b6h2lg-systemd-246.6
-root_prefix=/nix/store/iyayrhagfqccsrfzw2fqs2q8n4b6h2lg-systemd-246.6
+prefix=/usr
+root_prefix=/nix/store/n9lzlyhq8d9gv9hdi0gay1plmzlz70j9-systemd-247
rootprefix=${root_prefix}
sysconf_dir=/etc
sysconfdir=${sysconf_dir}
@@ -26,10 +26,10 @@
systemd_system_preset_dir=${rootprefix}/lib/systemd/system-preset
systemdsystempresetdir=${systemd_system_preset_dir}
-systemd_user_unit_dir=${prefix}/lib/systemd/user
+systemd_user_unit_dir=/usr/lib/systemd/user
systemduserunitdir=${systemd_user_unit_dir}
-systemd_user_preset_dir=${prefix}/lib/systemd/user-preset
+systemd_user_preset_dir=/usr/lib/systemd/user-preset
systemduserpresetdir=${systemd_user_preset_dir}
systemd_system_conf_dir=${sysconfdir}/systemd/system
@@ -48,7 +48,7 @@
systemd_system_generator_dir=${root_prefix}/lib/systemd/system-generators
systemdsystemgeneratordir=${systemd_system_generator_dir}
-systemd_user_generator_dir=${prefix}/lib/systemd/user-generators
+systemd_user_generator_dir=/usr/lib/systemd/user-generators
systemdusergeneratordir=${systemd_user_generator_dir}
systemd_system_generator_path=/run/systemd/system-generators:/etc/systemd/system-generators:/usr/local/lib/systemd/system-generators:${systemd_system_generator_dir}
@@ -63,7 +63,7 @@
systemd_shutdown_dir=${root_prefix}/lib/systemd/system-shutdown
systemdshutdowndir=${systemd_shutdown_dir}
-tmpfiles_dir=${prefix}/lib/tmpfiles.d
+tmpfiles_dir=/usr/lib/tmpfiles.d
tmpfilesdir=${tmpfiles_dir}
sysusers_dir=${rootprefix}/lib/sysusers.d
@@ -78,7 +78,7 @@
modules_load_dir=${rootprefix}/lib/modules-load.d
modulesloaddir=${modules_load_dir}
-catalog_dir=${prefix}/lib/systemd/catalog
+catalog_dir=/usr/lib/systemd/catalog
catalogdir=${catalog_dir}
system_uid_max=999
@@ -99,4 +99,4 @@
Name: systemd
Description: systemd System and Service Manager
URL: https://www.freedesktop.org/wiki/Software/systemd
-Version: 246
+Version: 247 |
|
I don't think that will break anything. Those PKG config variables are there to install Systemd units to the right place. Which doesn't make any sense in NixOS as it points to a path that is immutable and in NixOS instead we use the module system to install Systemd units. Edit: ah but the |
|
Edit: ah but the prefix might matter. I see. As that isn't interpolated anymore Does NixOS modify that in third-party pkg-configs? |
|
Normally, projects are expected to override |
|
systemd's pkgconfig has changed in systemd/systemd@6e65df8, which was part of systemd/systemd#17009. If I read https://www.bassi.io/articles/2018/03/15/pkg-config-and-paths/ and pick
out of this… Should we open an upstream issue? |
|
Yes, we should consider this an upstream regression. This is important for two reasons:
In either case you want to support overridable prefix so a project can be successfully installed as per https://www.bassi.io/articles/2018/03/15/pkg-config-and-paths/. Hardcoding the prefix means projects will no longer have reason (or a sensible way) to install the data relative to prexix (which will be |
|
I reverted the said commit for now. And upstream solution might take more time than I would want to block staging for: #106044 |
|
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
|
@Kiwi the pkg-config build issue is resolved |
|
oh yeah I built it on staging/staging-next/and master last night but forgot to comment |
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/bitwarden/desktop/releases.
meta.description for bitwarden is: "A secure and free password manager for all of your devices"
meta.homepage for bitwarden is: "https://bitwarden.com"
meta.changelog for bitwarden is: ""
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests, if any, passed0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 1.23.1 with grep in /nix/store/lmhqr7dhzlb9ycprpa9fgs67g74z9qiw-bitwarden-1.23.1
directory tree listing: https://gist.github.com/3936b1be9082e61c8688a7c6d9b2f21c
du listing: https://gist.github.com/382ed38ba43948446f403e8c8b74ad5f
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
NixPkgs review skipped
Maintainer pings
cc @Kiwi for testing.