Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apple/macbook-pro: add support for 14,1 #486

Merged
merged 2 commits into from
Oct 27, 2022
Merged

apple/macbook-pro: add support for 14,1 #486

merged 2 commits into from
Oct 27, 2022

Conversation

vs49688
Copy link
Contributor

@vs49688 vs49688 commented Oct 20, 2022

Extracted from my system configs. There's still a few issues with this machine:

  1. Audio is a lost cause. Will probably need to bribe an Apple or Cirrus engineer for the datasheet.
  2. The thunderbolt module will oops upon system resume, and subsequently refuse to work until next reboot.
  3. The d3cold state needs to be disabled on the NVME controller for it to wake up.
  4. The Bluetooth UART (/dev/ttyS0) is created and then deleted by udev in early boot. I am yet to figure out why. Hack around it by reloading the 8250_dw module, causing it to be re-created.

Any ideas for an alternative to the /dev/ttyS0 hack are welcome,.

Extracted from my system configs. There's still a few issues with this
machine:

1. Audio is a lost cause. Will probably need to bribe an Apple or Cirrus
   engineer for the datasheet.
2. The thunderbolt module will oops upon system resume, and subsequently
   refuse to work until next reboot.
3. The d3cold state needs to be disabled on the NVME controller for it
   to wake up.
4. The Bluetooth UART (/dev/ttyS0) is created and then deleted by udev
   in early boot. I am yet to figure out why. Hack around it by
   reloading the 8250_dw module, causing it to be re-created.
@vs49688 vs49688 marked this pull request as ready for review October 20, 2022 14:30
Doesn't require Nix to keep around the entire nixos-hardware repo.
@Mic92
Copy link
Member

Mic92 commented Oct 27, 2022

bors merge

1 similar comment
@Mic92
Copy link
Member

Mic92 commented Oct 27, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 27, 2022

Already running a review

@Mic92
Copy link
Member

Mic92 commented Oct 27, 2022

bors abort

@bors
Copy link
Contributor

bors bot commented Oct 27, 2022

Build succeeded:

@bors bors bot merged commit e0edd21 into NixOS:master Oct 27, 2022
@yisraeldov
Copy link

I was unable to get this to work.

Re: sound, you might want to look at what they are doing in winesapOs. There everything was working, touchbar sound camera

@vs49688
Copy link
Contributor Author

vs49688 commented Nov 23, 2022

I was unable to get this to work.

Which part specifically?

Re: sound, you might want to look at what they are doing in winesapOs. There everything was working, touchbar sound camera

There are experimental patches, but they don't apply cleanly, and I don't have the patience to fix them/re-build the kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants