libstore: convert more Path to std::filesystem::path#15339
Merged
Ericson2314 merged 3 commits intoNixOS:masterfrom Feb 25, 2026
Merged
libstore: convert more Path to std::filesystem::path#15339Ericson2314 merged 3 commits intoNixOS:masterfrom
Path to std::filesystem::path#15339Ericson2314 merged 3 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
new-cli
Ericson2314
reviewed
Feb 25, 2026
| std::stringstream ss(config.secretKeyFiles); | ||
| Path keyPath; | ||
| std::string keyPath; | ||
| while (std::getline(ss, keyPath, ',')) { |
Member
There was a problem hiding this comment.
@xokdvium we should probably replace with one our split/tokenize functions?
Ericson2314
reviewed
Feb 25, 2026
Ericson2314
reviewed
Feb 25, 2026
amaanq
force-pushed
the
convert-some-more-path
branch
from
a07e267 to
b43bcf4
Compare
Ericson2314
reviewed
Feb 25, 2026
Ericson2314
reviewed
Feb 25, 2026
Ericson2314
reviewed
Feb 25, 2026
Ericson2314
reviewed
Feb 25, 2026
Ericson2314
reviewed
Feb 25, 2026
Ericson2314
reviewed
Feb 25, 2026
amaanq
force-pushed
the
convert-some-more-path
branch
from
b43bcf4 to
5ff6d2d
Compare
github-actions
bot
added
the
fetching
amaanq
force-pushed
the
convert-some-more-path
branch
from
5ff6d2d to
5e2124a
Compare
Ericson2314
reviewed
Feb 25, 2026
amaanq
force-pushed
the
convert-some-more-path
branch
2 times, most recently
from
9717f94 to
37b33f1
Compare
This commit converts local filesystem paths throughout libstore from the string-based `Path` typedef to `std::filesystem::path`.
amaanq
force-pushed
the
convert-some-more-path
branch
from
37b33f1 to
d4b9a81
Compare
Ericson2314
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit converts local filesystem paths throughout libstore from the string-based
Pathtypedef tostd::filesystem::path.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.