libstore: refactor tryToBuild with coroutine lambdas and RAII#15274
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 17, 2026
Merged
libstore: refactor tryToBuild with coroutine lambdas and RAII#15274Ericson2314 merged 1 commit intoNixOS:masterfrom
tryToBuild with coroutine lambdas and RAII#15274Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
amaanq
force-pushed
the
tryToBuild-raii
branch
7 times, most recently
from
9ee527c to
d77e085
Compare
`tryToBuild` threaded a single `PathLocks outputLocks` by reference across all build phases and managed a `std::unique_ptr<Activity> actLock` with explicit `if (!actLock)` guards and `.reset()` calls around the hook retry loop. This commit introduces coroutine lambdas for the three phases: `tryHookLoop` owns a `PathLocks` in a scoped block for the first attempt and per-iteration in the retry loop, `tryBuildLocally` acquires its own `PathLocks`, and the hook-wait `Activity` is a stack variable scoped to the postpone block.
amaanq
force-pushed
the
tryToBuild-raii
branch
from
d77e085 to
b9acea9
Compare
Ericson2314
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tryToBuildthreaded a singlePathLocks outputLocksby reference across all build phases and managed astd::unique_ptr<Activity> actLockwith explicitif (!actLock)guards and.reset()calls around the hook retry loop. This commit introduces coroutine lambdas for the three phases:tryHookLoopowns aPathLocksin a scoped block for the first attempt and per-iteration in the retry loop,tryBuildLocallyacquires its ownPathLocks, and the hook-waitActivityis a stack variable scoped to the postpone block.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.