libstore-tests: Fix mTLS test for redirect, correctly propagate tries#15240
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 15, 2026
Merged
libstore-tests: Fix mTLS test for redirect, correctly propagate tries#15240Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
The fake cacert didn't have subjectAltName for 127.0.0.1, so the test was failing for a different reason. Also `tries` setting wasn't being respected. There's no callsite specifying it in the request, so just use the one specified in the FileTransferSettings and remove the fields from the FileTransferRequest.
Ericson2314
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The fake cacert didn't have
subjectAltNamefor127.0.0.1, so the test was failing for a different reason. Alsotriessetting wasn't being respected. There's no callsite specifying it in the request, so just use the one specified in theFileTransferSettingsand remove the fields from theFileTransferRequest.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.