globals: change store settings to use StoreReference types directly #15192
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 11, 2026
Merged
globals: change store settings to use StoreReference types directly #15192Ericson2314 merged 1 commit intoNixOS:masterfrom
StoreReference types directly #15192Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
amaanq
changed the title
github-actions
bot
added
new-cli
amaanq
changed the title
amaanq
force-pushed
the
store-reference-types
branch
2 times, most recently
from
06d177b to
17c9d20
Compare
amaanq
force-pushed
the
store-reference-types
branch
4 times, most recently
from
6cbfcd5 to
400df01
Compare
amaanq
changed the title
StoreReference types directly
amaanq
force-pushed
the
store-reference-types
branch
10 times, most recently
from
0c02f2c to
0ea3212
Compare
amaanq
force-pushed
the
store-reference-types
branch
from
0ea3212 to
336fd02
Compare
Ericson2314
reviewed
Feb 11, 2026
amaanq
force-pushed
the
store-reference-types
branch
10 times, most recently
from
c95950f to
8594cd7
Compare
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
force-pushed
the
store-reference-types
branch
from
8594cd7 to
857fd2a
Compare
Ericson2314
approved these changes
Feb 11, 2026
This was referenced Feb 11, 2026
Contributor
|
On the latest master I started getting an error with this in my nixos config, while it previously worked. {
nix.settings.trusted-substituters = ["nixremote"]; # a name from .ssh/config
}Git bisect points to 857fd2a (this PR). |
Member
|
Did your substituter actually work? or was it ignoring it (perhaps silently) as invalid? |
Contributor
|
Nope, now that I look, I didn't have it set in So it was invalid before, but didn't hard error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
storeUri,substituters, andtrustedSubstituterssettings nowstore typed
StoreReferencevalues directly instead of raw strings,so callers work with the real types without manual parsing.
Context
This is a reworked version of #10761.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.