Make store setting and store flags use StoreReference#10761
Closed
Ericson2314 wants to merge 1 commit intomasterfrom
Closed
Make store setting and store flags use StoreReference#10761Ericson2314 wants to merge 1 commit intomasterfrom
StoreReference#10761Ericson2314 wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
new-cli
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
Change the private settings from strings to typed StoreReference values. Add BaseSetting specializations via a bridge header and JSON serialization for StoreReference. Based on NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. Based on the approach from NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The private `storeUri`, `substituters`, and `trustedSubstituters` settings previously stored raw strings and parsed them on demand in the accessors. This commit changes them to store typed `StoreReference` values directly, simplifying the accessors to just forward `.get()`. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
Change `storeUri`, `substituters`, and `trustedSubstituters` from raw string types (`Setting<std::string>`, `Setting<Strings>`, `Setting<StringSet>`) to typed `StoreReference` types (`Setting<StoreReference>`, `Setting<std::vector<StoreReference>>`, `Setting<std::set<StoreReference>>`). Callers now work with the typed fields directly instead of manually parsing strings into `StoreReference` values on each access. A bridge header `store-config-impl.hh` declares the `BaseSetting` specializations needed, and JSON serialization is added for `StoreReference` to support `nix show-config --json`. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 11, 2026
The `storeUri`, `substituters`, and `trustedSubstituters` settings now store typed `StoreReference` values directly instead of raw strings, so callers work with the real types without manual parsing. This is a reworked version of NixOS#10761.
Member
Author
|
Closed in favor of #15192, which should be merged shortly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Better to be more typed!
Note sure what the crash is about yet.
Context
Follows up from the recent #9839
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.