Merged
Conversation
Ericson2314
reviewed
Feb 10, 2026
Comment on lines
-416
to
-417
| listeningSockets.clear(); | ||
|
|
Member
There was a problem hiding this comment.
(writing down what we said on call) yeah will need to be a callback because scoping.
Ericson2314
reviewed
Feb 10, 2026
amaanq
force-pushed
the
serve-unix-socket
branch
2 times, most recently
from
c5524d6 to
e1cc9ff
Compare
Ericson2314
reviewed
Feb 10, 2026
amaanq
force-pushed
the
serve-unix-socket
branch
from
e1cc9ff to
2129463
Compare
Ericson2314
approved these changes
Feb 10, 2026
Ericson2314
force-pushed
the
serve-unix-socket
branch
from
2129463 to
bc1bba5
Compare
This commit extracts the Unix domain socket server loop (`PeerInfo`, `getPeerInfo`, and the systemd socket activation / poll / accept loop) from `src/nix/unix/daemon.cc` into a reusable `unix::serveUnixSocket` function in `libcmd`.
Ericson2314
force-pushed
the
serve-unix-socket
branch
from
bc1bba5 to
6674c23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit extracts the Unix domain socket server loop (
PeerInfo,getPeerInfo, and the systemd socket activation / poll / accept loop) fromsrc/nix/unix/daemon.ccinto a reusableunix::serveUnixSocketfunction inlibcmd.Context
This was split out from #15184.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.